api_pim.rs
| 1 | //! CalDAV and CardDAV: discovery, collections, properties and objects. |
| 2 | |
| 3 | mod common; |
| 4 | |
| 5 | use axum::http::{Method, StatusCode}; |
| 6 | use common::*; |
| 7 | use pimdav::xml::{self, APPLE, CALDAV, CALSERVER, CARDDAV, DAV, Name}; |
| 8 | use serde_json::json; |
| 9 | use xmltree::Element; |
| 10 | |
| 11 | const ALICE: &str = "alice"; |
| 12 | const PW: &str = "alice12345"; |
| 13 | |
| 14 | async fn setup() -> (Env, String) { |
| 15 | let env = Env::new().await; |
| 16 | let admin = env.admin().await; |
| 17 | create_user(&admin, ALICE, PW, &[]).await; |
| 18 | (env, basic(ALICE, PW)) |
| 19 | } |
| 20 | |
| 21 | async fn req( |
| 22 | env: &Env, |
| 23 | verb: &str, |
| 24 | path: &str, |
| 25 | auth: &str, |
| 26 | extra: &[(&str, &str)], |
| 27 | body: &str, |
| 28 | ) -> Resp { |
| 29 | let mut headers = vec![("authorization", auth)]; |
| 30 | headers.extend_from_slice(extra); |
| 31 | Client::new(env.app.clone()) |
| 32 | .raw( |
| 33 | Method::from_bytes(verb.as_bytes()).unwrap(), |
| 34 | path, |
| 35 | &headers, |
| 36 | body.as_bytes().to_vec(), |
| 37 | ) |
| 38 | .await |
| 39 | } |
| 40 | |
| 41 | fn propfind_body(props: &[(&str, &str)]) -> String { |
| 42 | let props: String = props |
| 43 | .iter() |
| 44 | .map(|(ns, l)| format!("<{l} xmlns=\"{ns}\"/>")) |
| 45 | .collect(); |
| 46 | format!("<d:propfind xmlns:d=\"DAV:\"><d:prop>{props}</d:prop></d:propfind>") |
| 47 | } |
| 48 | |
| 49 | /// `href -> [(status, property element)]` of a multistatus. |
| 50 | fn parse_multistatus(r: &Resp) -> Vec<(String, Vec<(u16, Element)>)> { |
| 51 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{}", r.text()); |
| 52 | let root = Element::parse(r.body.as_slice()).unwrap(); |
| 53 | xml::elements(&root) |
| 54 | .map(|resp| { |
| 55 | let href = xml::text(xml::child(resp, DAV, "href").unwrap()); |
| 56 | let props = xml::elements(resp) |
| 57 | .filter(|e| Name::of(e).is(DAV, "propstat")) |
| 58 | .flat_map(|ps| { |
| 59 | let code: u16 = xml::text(xml::child(ps, DAV, "status").unwrap()) |
| 60 | .split(' ') |
| 61 | .nth(1) |
| 62 | .unwrap() |
| 63 | .parse() |
| 64 | .unwrap(); |
| 65 | let prop = xml::child(ps, DAV, "prop").unwrap(); |
| 66 | xml::elements(prop) |
| 67 | .map(move |p| (code, p.clone())) |
| 68 | .collect::<Vec<_>>() |
| 69 | }) |
| 70 | .collect(); |
| 71 | (href, props) |
| 72 | }) |
| 73 | .collect() |
| 74 | } |
| 75 | |
| 76 | /// The property of `href` with status 200. |
| 77 | fn prop( |
| 78 | ms: &[(String, Vec<(u16, Element)>)], |
| 79 | href: &str, |
| 80 | ns: &str, |
| 81 | local: &str, |
| 82 | ) -> Option<Element> { |
| 83 | ms.iter() |
| 84 | .find(|(h, _)| h == href) |
| 85 | .unwrap_or_else(|| panic!("no response for {href}")) |
| 86 | .1 |
| 87 | .iter() |
| 88 | .find(|(code, p)| *code == 200 && Name::of(p).is(ns, local)) |
| 89 | .map(|(_, p)| p.clone()) |
| 90 | } |
| 91 | |
| 92 | fn prop_text( |
| 93 | ms: &[(String, Vec<(u16, Element)>)], |
| 94 | href: &str, |
| 95 | ns: &str, |
| 96 | local: &str, |
| 97 | ) -> Option<String> { |
| 98 | prop(ms, href, ns, local).map(|p| xml::text(&p)) |
| 99 | } |
| 100 | |
| 101 | fn hrefs_of(p: &Element) -> Vec<String> { |
| 102 | xml::elements(p).map(xml::text).collect() |
| 103 | } |
| 104 | |
| 105 | fn error_condition(r: &Resp) -> Name { |
| 106 | let root = Element::parse(r.body.as_slice()).unwrap_or_else(|_| panic!("{}", r.text())); |
| 107 | assert!(Name::of(&root).is(DAV, "error"), "{}", r.text()); |
| 108 | Name::of(xml::elements(&root).next().unwrap()) |
| 109 | } |
| 110 | |
| 111 | const HOME: &str = "/pim/calendars/alice/"; |
| 112 | const CAL: &str = "/pim/calendars/alice/default/"; |
| 113 | const BOOK: &str = "/pim/addressbooks/alice/default/"; |
| 114 | const INBOX: &str = "/pim/calendars/alice/inbox/"; |
| 115 | const OUTBOX: &str = "/pim/calendars/alice/outbox/"; |
| 116 | |
| 117 | fn event(uid: &str, summary: &str) -> String { |
| 118 | format!( |
| 119 | "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//t//EN\r\nBEGIN:VEVENT\r\nUID:{uid}\r\nDTSTAMP:20260101T000000Z\r\nDTSTART:20260101T100000Z\r\nSUMMARY:{summary}\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n" |
| 120 | ) |
| 121 | } |
| 122 | |
| 123 | #[tokio::test] |
| 124 | async fn discovery() { |
| 125 | let (env, auth) = setup().await; |
| 126 | |
| 127 | let r = req(&env, "PROPFIND", "/pim/", "", &[], "").await; |
| 128 | assert_eq!(r.status, StatusCode::UNAUTHORIZED); |
| 129 | assert!(r.header("www-authenticate").is_some()); |
| 130 | |
| 131 | let r = req(&env, "PROPFIND", "/.well-known/caldav", &auth, &[], "").await; |
| 132 | assert_eq!(r.status, StatusCode::TEMPORARY_REDIRECT); |
| 133 | assert_eq!(r.header("location").as_deref(), Some("/pim/")); |
| 134 | |
| 135 | // A Basic login spelled in another case still gets the stored spelling. |
| 136 | let body = propfind_body(&[(DAV, "current-user-principal")]); |
| 137 | let r = req( |
| 138 | &env, |
| 139 | "PROPFIND", |
| 140 | "/pim/", |
| 141 | &basic("ALICE", PW), |
| 142 | &[("depth", "0")], |
| 143 | &body, |
| 144 | ) |
| 145 | .await; |
| 146 | let ms = parse_multistatus(&r); |
| 147 | let p = prop(&ms, "/pim/", DAV, "current-user-principal").unwrap(); |
| 148 | assert_eq!(hrefs_of(&p), ["/pim/principals/alice/"]); |
| 149 | |
| 150 | let body = propfind_body(&[ |
| 151 | (CALDAV, "calendar-home-set"), |
| 152 | (CARDDAV, "addressbook-home-set"), |
| 153 | (CALDAV, "calendar-user-address-set"), |
| 154 | (DAV, "displayname"), |
| 155 | (DAV, "no-such-prop"), |
| 156 | ]); |
| 157 | let r = req( |
| 158 | &env, |
| 159 | "PROPFIND", |
| 160 | "/pim/principals/alice/", |
| 161 | &auth, |
| 162 | &[("depth", "0")], |
| 163 | &body, |
| 164 | ) |
| 165 | .await; |
| 166 | let ms = parse_multistatus(&r); |
| 167 | let p = "/pim/principals/alice/"; |
| 168 | assert_eq!( |
| 169 | hrefs_of(&prop(&ms, p, CALDAV, "calendar-home-set").unwrap()), |
| 170 | [HOME] |
| 171 | ); |
| 172 | assert_eq!( |
| 173 | hrefs_of(&prop(&ms, p, CARDDAV, "addressbook-home-set").unwrap()), |
| 174 | ["/pim/addressbooks/alice/"] |
| 175 | ); |
| 176 | // Only the mailto address, preferred, so Apple picks it as the identity. |
| 177 | let set = prop(&ms, p, CALDAV, "calendar-user-address-set").unwrap(); |
| 178 | assert_eq!(hrefs_of(&set), ["mailto:alice@dovenest.invalid"]); |
| 179 | let href = xml::child(&set, DAV, "href").unwrap(); |
| 180 | assert_eq!( |
| 181 | href.attributes.get("preferred").map(String::as_str), |
| 182 | Some("1") |
| 183 | ); |
| 184 | assert_eq!( |
| 185 | prop_text(&ms, p, DAV, "displayname").as_deref(), |
| 186 | Some(ALICE) |
| 187 | ); |
| 188 | assert!( |
| 189 | ms[0] |
| 190 | .1 |
| 191 | .iter() |
| 192 | .any(|(c, e)| *c == 404 && Name::of(e).is(DAV, "no-such-prop")) |
| 193 | ); |
| 194 | |
| 195 | // An app password works as well. |
| 196 | let admin = login(&env, ALICE, PW).await; |
| 197 | let r = admin |
| 198 | .post_json("/api/auth/app-passwords", &json!({ "name": "phone" })) |
| 199 | .await; |
| 200 | let secret = r.json()["secret"].as_str().unwrap().to_string(); |
| 201 | let r = req( |
| 202 | &env, |
| 203 | "PROPFIND", |
| 204 | "/pim/", |
| 205 | &basic("x", &secret), |
| 206 | &[("depth", "0")], |
| 207 | "", |
| 208 | ) |
| 209 | .await; |
| 210 | assert_eq!(r.status, StatusCode::MULTI_STATUS); |
| 211 | |
| 212 | let r = req(&env, "OPTIONS", "/pim/", &auth, &[], "").await; |
| 213 | assert!(r.header("dav").unwrap().contains("calendar-access")); |
| 214 | } |
| 215 | |
| 216 | #[tokio::test] |
| 217 | async fn homes_list_the_default_collections() { |
| 218 | let (env, auth) = setup().await; |
| 219 | let r = req(&env, "PROPFIND", HOME, &auth, &[("depth", "1")], "").await; |
| 220 | let ms = parse_multistatus(&r); |
| 221 | // The home, the calendar, the birthday calendar, and the scheduling |
| 222 | // inbox and outbox. |
| 223 | assert_eq!(ms.len(), 5, "{}", r.text()); |
| 224 | for (href, kind) in [(INBOX, "schedule-inbox"), (OUTBOX, "schedule-outbox")] { |
| 225 | let rt = prop(&ms, href, DAV, "resourcetype").unwrap(); |
| 226 | assert!(xml::child(&rt, CALDAV, kind).is_some(), "{href}"); |
| 227 | } |
| 228 | assert_eq!( |
| 229 | prop(&ms, INBOX, CALDAV, "schedule-default-calendar-URL").map(|p| hrefs_of(&p)), |
| 230 | Some(vec![CAL.to_string()]) |
| 231 | ); |
| 232 | let rt = prop(&ms, CAL, DAV, "resourcetype").unwrap(); |
| 233 | assert!(xml::child(&rt, CALDAV, "calendar").is_some()); |
| 234 | assert_eq!( |
| 235 | prop_text(&ms, CAL, DAV, "displayname").as_deref(), |
| 236 | Some("Calendar") |
| 237 | ); |
| 238 | let comps = prop(&ms, CAL, CALDAV, "supported-calendar-component-set").unwrap(); |
| 239 | let comps: Vec<_> = xml::elements(&comps) |
| 240 | .map(|c| c.attributes["name"].clone()) |
| 241 | .collect(); |
| 242 | assert_eq!(comps, ["VEVENT", "VTODO", "VJOURNAL"]); |
| 243 | assert!(prop_text(&ms, CAL, CALSERVER, "getctag").is_some()); |
| 244 | assert!( |
| 245 | prop_text(&ms, CAL, DAV, "sync-token") |
| 246 | .unwrap() |
| 247 | .starts_with("urn:") |
| 248 | ); |
| 249 | |
| 250 | let r = req( |
| 251 | &env, |
| 252 | "PROPFIND", |
| 253 | "/pim/addressbooks/alice/", |
| 254 | &auth, |
| 255 | &[("depth", "1")], |
| 256 | "", |
| 257 | ) |
| 258 | .await; |
| 259 | let ms = parse_multistatus(&r); |
| 260 | let rt = prop(&ms, BOOK, DAV, "resourcetype").unwrap(); |
| 261 | assert!(xml::child(&rt, CARDDAV, "addressbook").is_some()); |
| 262 | |
| 263 | let r = req(&env, "PROPFIND", HOME, &auth, &[("depth", "infinity")], "").await; |
| 264 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 265 | assert!(error_condition(&r).is(DAV, "propfind-finite-depth")); |
| 266 | } |
| 267 | |
| 268 | #[tokio::test] |
| 269 | async fn other_users_are_off_limits() { |
| 270 | let (env, auth) = setup().await; |
| 271 | for path in ["/pim/calendars/admin/", "/pim/calendars/admin/default/"] { |
| 272 | let r = req(&env, "PROPFIND", path, &auth, &[("depth", "0")], "").await; |
| 273 | assert_eq!(r.status, StatusCode::FORBIDDEN, "{path}"); |
| 274 | } |
| 275 | // Another account's principal is readable, for scheduling. |
| 276 | let body = propfind_body(&[ |
| 277 | (DAV, "displayname"), |
| 278 | (CALDAV, "calendar-user-address-set"), |
| 279 | (CARDDAV, "addressbook-home-set"), |
| 280 | ]); |
| 281 | let p = "/pim/principals/admin/"; |
| 282 | let r = req(&env, "PROPFIND", p, &auth, &[("depth", "0")], &body).await; |
| 283 | let ms = parse_multistatus(&r); |
| 284 | assert_eq!( |
| 285 | prop_text(&ms, p, DAV, "displayname").as_deref(), |
| 286 | Some("admin") |
| 287 | ); |
| 288 | let addresses = hrefs_of(&prop(&ms, p, CALDAV, "calendar-user-address-set").unwrap()); |
| 289 | assert!(addresses.contains(&"mailto:admin@dovenest.invalid".to_string())); |
| 290 | assert!(prop(&ms, p, CARDDAV, "addressbook-home-set").is_none()); |
| 291 | |
| 292 | let r = req(&env, "PROPFIND", "/pim/principals/nobody/", &auth, &[], "").await; |
| 293 | assert_eq!(r.status, StatusCode::NOT_FOUND); |
| 294 | } |
| 295 | |
| 296 | #[tokio::test] |
| 297 | async fn make_and_patch_collections() { |
| 298 | let (env, auth) = setup().await; |
| 299 | let work = "/pim/calendars/alice/work/"; |
| 300 | let body = r##"<c:mkcalendar xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:i="http://apple.com/ns/ical/"> |
| 301 | <d:set><d:prop> |
| 302 | <d:displayname>Work</d:displayname> |
| 303 | <i:calendar-color>#00ff00</i:calendar-color> |
| 304 | <c:supported-calendar-component-set><c:comp name="VTODO"/></c:supported-calendar-component-set> |
| 305 | </d:prop></d:set></c:mkcalendar>"##; |
| 306 | let r = req(&env, "MKCALENDAR", work, &auth, &[], body).await; |
| 307 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 308 | let r = req(&env, "MKCALENDAR", work, &auth, &[], "").await; |
| 309 | assert_eq!(r.status, StatusCode::METHOD_NOT_ALLOWED); |
| 310 | |
| 311 | let r = req(&env, "PROPFIND", work, &auth, &[("depth", "0")], "").await; |
| 312 | let ms = parse_multistatus(&r); |
| 313 | assert_eq!( |
| 314 | prop_text(&ms, work, DAV, "displayname").as_deref(), |
| 315 | Some("Work") |
| 316 | ); |
| 317 | assert_eq!( |
| 318 | prop_text(&ms, work, APPLE, "calendar-color").as_deref(), |
| 319 | Some("#00ff00") |
| 320 | ); |
| 321 | let ctag = prop_text(&ms, work, CALSERVER, "getctag").unwrap(); |
| 322 | |
| 323 | // One bad property fails the whole request, and nothing is created. |
| 324 | let bad = body.replace("VTODO", "VCARD"); |
| 325 | let r = req( |
| 326 | &env, |
| 327 | "MKCALENDAR", |
| 328 | "/pim/calendars/alice/bad/", |
| 329 | &auth, |
| 330 | &[], |
| 331 | &bad, |
| 332 | ) |
| 333 | .await; |
| 334 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 335 | assert!(r.text().contains("mkcalendar-response"), "{}", r.text()); |
| 336 | let r = req( |
| 337 | &env, |
| 338 | "PROPFIND", |
| 339 | "/pim/calendars/alice/bad/", |
| 340 | &auth, |
| 341 | &[("depth", "0")], |
| 342 | "", |
| 343 | ) |
| 344 | .await; |
| 345 | assert_eq!(r.status, StatusCode::NOT_FOUND); |
| 346 | |
| 347 | // A plain MKCOL cannot make a calendar, an extended one makes an address book. |
| 348 | let r = req(&env, "MKCOL", "/pim/calendars/alice/plain/", &auth, &[], "").await; |
| 349 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 350 | let mkcol = r#"<d:mkcol xmlns:d="DAV:" xmlns:card="urn:ietf:params:xml:ns:carddav"><d:set><d:prop> |
| 351 | <d:resourcetype><d:collection/><card:addressbook/></d:resourcetype> |
| 352 | <d:displayname>Friends</d:displayname></d:prop></d:set></d:mkcol>"#; |
| 353 | let r = req( |
| 354 | &env, |
| 355 | "MKCOL", |
| 356 | "/pim/addressbooks/alice/friends/", |
| 357 | &auth, |
| 358 | &[], |
| 359 | mkcol, |
| 360 | ) |
| 361 | .await; |
| 362 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 363 | |
| 364 | let patch = r#"<d:propertyupdate xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav"> |
| 365 | <d:set><d:prop><d:displayname>Job</d:displayname><c:calendar-description>Tasks</c:calendar-description></d:prop></d:set> |
| 366 | </d:propertyupdate>"#; |
| 367 | let r = req(&env, "PROPPATCH", work, &auth, &[], patch).await; |
| 368 | let ms = parse_multistatus(&r); |
| 369 | assert!(ms[0].1.iter().all(|(c, _)| *c == 200)); |
| 370 | let r = req(&env, "PROPFIND", work, &auth, &[("depth", "0")], "").await; |
| 371 | let ms = parse_multistatus(&r); |
| 372 | assert_eq!( |
| 373 | prop_text(&ms, work, DAV, "displayname").as_deref(), |
| 374 | Some("Job") |
| 375 | ); |
| 376 | assert_eq!( |
| 377 | prop_text(&ms, work, CALDAV, "calendar-description").as_deref(), |
| 378 | Some("Tasks") |
| 379 | ); |
| 380 | assert_ne!(prop_text(&ms, work, CALSERVER, "getctag").unwrap(), ctag); |
| 381 | |
| 382 | let patch = r#"<d:propertyupdate xmlns:d="DAV:"><d:set><d:prop> |
| 383 | <d:displayname>Never</d:displayname><d:getetag>x</d:getetag></d:prop></d:set></d:propertyupdate>"#; |
| 384 | let r = req(&env, "PROPPATCH", work, &auth, &[], patch).await; |
| 385 | let ms = parse_multistatus(&r); |
| 386 | let codes: Vec<u16> = ms[0].1.iter().map(|(c, _)| *c).collect(); |
| 387 | assert_eq!(codes, [424, 403]); |
| 388 | let r = req(&env, "PROPFIND", work, &auth, &[("depth", "0")], "").await; |
| 389 | let ms = parse_multistatus(&r); |
| 390 | assert_eq!( |
| 391 | prop_text(&ms, work, DAV, "displayname").as_deref(), |
| 392 | Some("Job") |
| 393 | ); |
| 394 | |
| 395 | let patch = r#"<d:propertyupdate xmlns:d="DAV:"><d:set><d:prop> |
| 396 | <d:displayname>Tab	bed</d:displayname></d:prop></d:set></d:propertyupdate>"#; |
| 397 | let r = req(&env, "PROPPATCH", work, &auth, &[], patch).await; |
| 398 | let ms = parse_multistatus(&r); |
| 399 | assert!(ms[0].1.iter().all(|(c, _)| *c != 200), "{}", r.text()); |
| 400 | let r = req(&env, "PROPFIND", work, &auth, &[("depth", "0")], "").await; |
| 401 | let ms = parse_multistatus(&r); |
| 402 | assert_eq!( |
| 403 | prop_text(&ms, work, DAV, "displayname").as_deref(), |
| 404 | Some("Job") |
| 405 | ); |
| 406 | |
| 407 | let r = req(&env, "DELETE", work, &auth, &[], "").await; |
| 408 | assert_eq!(r.status, StatusCode::NO_CONTENT); |
| 409 | let r = req(&env, "PROPFIND", work, &auth, &[("depth", "0")], "").await; |
| 410 | assert_eq!(r.status, StatusCode::NOT_FOUND); |
| 411 | } |
| 412 | |
| 413 | #[tokio::test] |
| 414 | async fn missing_dtstamp_is_added() { |
| 415 | let (env, auth) = setup().await; |
| 416 | let obj = format!("{CAL}s.ics"); |
| 417 | let sent = event("s", "One").replace("DTSTAMP:20260101T000000Z\r\n", ""); |
| 418 | let r = req(&env, "PUT", &obj, &auth, &[], &sent).await; |
| 419 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 420 | assert_eq!(r.header("etag"), None); |
| 421 | let stored = req(&env, "GET", &obj, &auth, &[], "").await.text(); |
| 422 | let (head, rest) = stored.split_once("BEGIN:VEVENT\r\nDTSTAMP:").unwrap(); |
| 423 | let (stamp, tail) = rest.split_once("\r\n").unwrap(); |
| 424 | assert_eq!(stamp.len(), 16, "{stored}"); |
| 425 | assert_eq!(format!("{head}BEGIN:VEVENT\r\n{tail}"), sent); |
| 426 | } |
| 427 | |
| 428 | #[tokio::test] |
| 429 | async fn calendar_objects() { |
| 430 | let (env, auth) = setup().await; |
| 431 | let obj = format!("{CAL}a.ics"); |
| 432 | |
| 433 | let r = req( |
| 434 | &env, |
| 435 | "PUT", |
| 436 | &obj, |
| 437 | &auth, |
| 438 | &[("if-none-match", "*")], |
| 439 | &event("a", "One"), |
| 440 | ) |
| 441 | .await; |
| 442 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 443 | let etag = r.header("etag").unwrap(); |
| 444 | |
| 445 | let r = req(&env, "GET", &obj, &auth, &[], "").await; |
| 446 | assert_eq!(r.status, StatusCode::OK); |
| 447 | assert_eq!(r.text(), event("a", "One")); |
| 448 | assert_eq!(r.header("etag"), Some(etag.clone())); |
| 449 | assert!( |
| 450 | r.header("content-type") |
| 451 | .unwrap() |
| 452 | .starts_with("text/calendar") |
| 453 | ); |
| 454 | let r = req(&env, "HEAD", &obj, &auth, &[], "").await; |
| 455 | assert_eq!(r.status, StatusCode::OK); |
| 456 | assert!(r.body.is_empty()); |
| 457 | let length = event("a", "One").len().to_string(); |
| 458 | assert_eq!(r.header("content-length"), Some(length)); |
| 459 | |
| 460 | let r = req( |
| 461 | &env, |
| 462 | "PUT", |
| 463 | &obj, |
| 464 | &auth, |
| 465 | &[("if-none-match", "*")], |
| 466 | &event("a", "Two"), |
| 467 | ) |
| 468 | .await; |
| 469 | assert_eq!(r.status, StatusCode::PRECONDITION_FAILED); |
| 470 | let r = req( |
| 471 | &env, |
| 472 | "PUT", |
| 473 | &obj, |
| 474 | &auth, |
| 475 | &[("if-match", "\"stale\"")], |
| 476 | &event("a", "Two"), |
| 477 | ) |
| 478 | .await; |
| 479 | assert_eq!(r.status, StatusCode::PRECONDITION_FAILED); |
| 480 | // If-Match compares strongly: a weak tag never matches. |
| 481 | let weak = format!("W/{etag}"); |
| 482 | let r = req( |
| 483 | &env, |
| 484 | "PUT", |
| 485 | &obj, |
| 486 | &auth, |
| 487 | &[("if-match", &weak)], |
| 488 | &event("a", "Two"), |
| 489 | ) |
| 490 | .await; |
| 491 | assert_eq!(r.status, StatusCode::PRECONDITION_FAILED); |
| 492 | |
| 493 | let before = parse_multistatus(&req(&env, "PROPFIND", CAL, &auth, &[("depth", "0")], "").await); |
| 494 | let r = req( |
| 495 | &env, |
| 496 | "PUT", |
| 497 | &obj, |
| 498 | &auth, |
| 499 | &[("if-match", &etag)], |
| 500 | &event("a", "Two"), |
| 501 | ) |
| 502 | .await; |
| 503 | assert_eq!(r.status, StatusCode::NO_CONTENT); |
| 504 | let new_etag = r.header("etag").unwrap(); |
| 505 | assert_ne!(new_etag, etag); |
| 506 | let after = parse_multistatus(&req(&env, "PROPFIND", CAL, &auth, &[("depth", "1")], "").await); |
| 507 | assert_ne!( |
| 508 | prop_text(&before, CAL, DAV, "sync-token"), |
| 509 | prop_text(&after, CAL, DAV, "sync-token") |
| 510 | ); |
| 511 | assert_eq!(prop_text(&after, &obj, DAV, "getetag"), Some(new_etag)); |
| 512 | |
| 513 | // The UID is already stored under another name. |
| 514 | let r = req( |
| 515 | &env, |
| 516 | "PUT", |
| 517 | &format!("{CAL}b.ics"), |
| 518 | &auth, |
| 519 | &[], |
| 520 | &event("a", "Dup"), |
| 521 | ) |
| 522 | .await; |
| 523 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 524 | assert!(error_condition(&r).is(CALDAV, "no-uid-conflict")); |
| 525 | assert!(r.text().contains(&obj), "{}", r.text()); |
| 526 | |
| 527 | let freebusy = event("j", "x").replace("VEVENT", "VFREEBUSY"); |
| 528 | let cases = [ |
| 529 | ("not a calendar".to_string(), "valid-calendar-data"), |
| 530 | ( |
| 531 | event("m", "x").replace("VERSION:2.0", "VERSION:2.0\r\nMETHOD:PUBLISH"), |
| 532 | "valid-calendar-object-resource", |
| 533 | ), |
| 534 | (freebusy, "supported-calendar-component"), |
| 535 | ]; |
| 536 | for (body, cond) in cases { |
| 537 | let r = req(&env, "PUT", &format!("{CAL}x.ics"), &auth, &[], &body).await; |
| 538 | assert_eq!(r.status, StatusCode::FORBIDDEN, "{cond}"); |
| 539 | assert!(error_condition(&r).is(CALDAV, cond), "{cond}: {}", r.text()); |
| 540 | } |
| 541 | |
| 542 | let r = req( |
| 543 | &env, |
| 544 | "PUT", |
| 545 | "/pim/calendars/alice/nope/x.ics", |
| 546 | &auth, |
| 547 | &[], |
| 548 | &event("x", "x"), |
| 549 | ) |
| 550 | .await; |
| 551 | assert_eq!(r.status, StatusCode::CONFLICT); |
| 552 | |
| 553 | let r = req( |
| 554 | &env, |
| 555 | "DELETE", |
| 556 | &obj, |
| 557 | &auth, |
| 558 | &[("if-match", "\"stale\"")], |
| 559 | "", |
| 560 | ) |
| 561 | .await; |
| 562 | assert_eq!(r.status, StatusCode::PRECONDITION_FAILED); |
| 563 | let r = req(&env, "DELETE", &obj, &auth, &[], "").await; |
| 564 | assert_eq!(r.status, StatusCode::NO_CONTENT); |
| 565 | let r = req(&env, "DELETE", &obj, &auth, &[], "").await; |
| 566 | assert_eq!(r.status, StatusCode::NOT_FOUND); |
| 567 | |
| 568 | let r = req(&env, "REPORT", CAL, &auth, &[], "").await; |
| 569 | assert_eq!(r.status, StatusCode::BAD_REQUEST); |
| 570 | } |
| 571 | |
| 572 | #[tokio::test] |
| 573 | async fn address_objects() { |
| 574 | let (env, auth) = setup().await; |
| 575 | let card = "BEGIN:VCARD\r\nVERSION:3.0\r\nUID:c1\r\nFN:Bob\r\nN:;Bob;;;\r\nEND:VCARD\r\n"; |
| 576 | let r = req(&env, "PUT", &format!("{BOOK}c1.vcf"), &auth, &[], card).await; |
| 577 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 578 | let r = req(&env, "GET", &format!("{BOOK}c1.vcf"), &auth, &[], "").await; |
| 579 | assert_eq!(r.text(), card); |
| 580 | assert!(r.header("content-type").unwrap().starts_with("text/vcard")); |
| 581 | |
| 582 | let r = req(&env, "PUT", &format!("{BOOK}c2.vcf"), &auth, &[], card).await; |
| 583 | assert!(error_condition(&r).is(CARDDAV, "no-uid-conflict")); |
| 584 | let r = req( |
| 585 | &env, |
| 586 | "PUT", |
| 587 | &format!("{BOOK}c3.vcf"), |
| 588 | &auth, |
| 589 | &[], |
| 590 | &event("e", "x"), |
| 591 | ) |
| 592 | .await; |
| 593 | assert!(error_condition(&r).is(CARDDAV, "valid-address-data")); |
| 594 | } |
| 595 | |
| 596 | #[tokio::test] |
| 597 | async fn the_default_calendar_stays() { |
| 598 | let (env, auth) = setup().await; |
| 599 | // Invitations arrive there (RFC 6638, 4.3). |
| 600 | let r = req(&env, "DELETE", CAL, &auth, &[], "").await; |
| 601 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 602 | assert!(error_condition(&r).is(CALDAV, "default-calendar-needed")); |
| 603 | let other = format!("{HOME}work/"); |
| 604 | assert_eq!( |
| 605 | req(&env, "MKCALENDAR", &other, &auth, &[], "").await.status, |
| 606 | StatusCode::CREATED |
| 607 | ); |
| 608 | assert_eq!( |
| 609 | req(&env, "DELETE", &other, &auth, &[], "").await.status, |
| 610 | StatusCode::NO_CONTENT |
| 611 | ); |
| 612 | // Nor can the inbox be made or removed by a client. |
| 613 | assert_eq!( |
| 614 | req(&env, "DELETE", INBOX, &auth, &[], "").await.status, |
| 615 | StatusCode::FORBIDDEN |
| 616 | ); |
| 617 | assert_eq!( |
| 618 | req( |
| 619 | &env, |
| 620 | "MKCALENDAR", |
| 621 | "/pim/calendars/alice/outbox/", |
| 622 | &auth, |
| 623 | &[], |
| 624 | "" |
| 625 | ) |
| 626 | .await |
| 627 | .status, |
| 628 | StatusCode::FORBIDDEN |
| 629 | ); |
| 630 | } |
| 631 | |
| 632 | #[tokio::test] |
| 633 | async fn deleting_a_user_deletes_their_collections() { |
| 634 | let env = Env::new().await; |
| 635 | let admin = env.admin().await; |
| 636 | create_user(&admin, ALICE, PW, &[]).await; |
| 637 | let auth = basic(ALICE, PW); |
| 638 | let r = req( |
| 639 | &env, |
| 640 | "PUT", |
| 641 | &format!("{CAL}a.ics"), |
| 642 | &auth, |
| 643 | &[], |
| 644 | &event("a", "x"), |
| 645 | ) |
| 646 | .await; |
| 647 | assert_eq!(r.status, StatusCode::CREATED); |
| 648 | let id = user_id(&admin, ALICE).await; |
| 649 | let r = admin.delete(&format!("/api/admin/users/{id}")).await; |
| 650 | assert_eq!(r.status, StatusCode::OK, "{}", r.text()); |
| 651 | let db = &env.state.db; |
| 652 | assert!( |
| 653 | db.pim_collections(id, server::db::PimKind::Calendar) |
| 654 | .await |
| 655 | .unwrap() |
| 656 | .is_empty() |
| 657 | ); |
| 658 | } |
| 659 | |
| 660 | // --------------------------------------------------------------------------- |
| 661 | // REPORT and MOVE |
| 662 | // --------------------------------------------------------------------------- |
| 663 | |
| 664 | /// `(href, status of the response itself)` of every response. |
| 665 | fn statuses(r: &Resp) -> Vec<(String, Option<u16>)> { |
| 666 | let root = Element::parse(r.body.as_slice()).unwrap(); |
| 667 | xml::elements(&root) |
| 668 | .filter(|e| Name::of(e).is(DAV, "response")) |
| 669 | .map(|resp| { |
| 670 | let href = xml::text(xml::child(resp, DAV, "href").unwrap()); |
| 671 | let code = xml::child(resp, DAV, "status") |
| 672 | .map(|s| xml::text(s).split(' ').nth(1).unwrap().parse().unwrap()); |
| 673 | (href, code) |
| 674 | }) |
| 675 | .collect() |
| 676 | } |
| 677 | |
| 678 | fn sync_token_of(r: &Resp) -> String { |
| 679 | let root = Element::parse(r.body.as_slice()).unwrap(); |
| 680 | xml::text(xml::child(&root, DAV, "sync-token").unwrap()) |
| 681 | } |
| 682 | |
| 683 | fn ics(body: &str) -> String { |
| 684 | format!("BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:-//t//EN\r\n{body}END:VCALENDAR\r\n") |
| 685 | } |
| 686 | |
| 687 | const LUNCH: &str = "BEGIN:VEVENT\r\nUID:lunch\r\nDTSTAMP:20260101T000000Z\r\nDTSTART:20260101T120000Z\r\nDTEND:20260101T130000Z\r\nSUMMARY:Team Lunch\r\nEND:VEVENT\r\n"; |
| 688 | const WEEKLY: &str = "BEGIN:VEVENT\r\nUID:weekly\r\nDTSTAMP:20260101T000000Z\r\nDTSTART;TZID=Europe/Berlin:20251201T090000\r\nDTEND;TZID=Europe/Berlin:20251201T093000\r\nRRULE:FREQ=WEEKLY\r\nSUMMARY:Standup\r\nEND:VEVENT\r\n"; |
| 689 | const TODO: &str = "BEGIN:VTODO\r\nUID:todo\r\nDTSTAMP:20260101T000000Z\r\nDUE:20260110T170000Z\r\nSUMMARY:Taxes\r\nEND:VTODO\r\n"; |
| 690 | |
| 691 | async fn put(env: &Env, auth: &str, path: &str, body: &str) { |
| 692 | let r = req(env, "PUT", path, auth, &[], body).await; |
| 693 | assert!(r.status.is_success(), "{path}: {}", r.text()); |
| 694 | } |
| 695 | |
| 696 | fn query(filter: &str, data: &str) -> String { |
| 697 | format!( |
| 698 | r#"<c:calendar-query xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav"> |
| 699 | <d:prop><d:getetag/>{data}</d:prop> |
| 700 | <c:filter><c:comp-filter name="VCALENDAR">{filter}</c:comp-filter></c:filter> |
| 701 | </c:calendar-query>"# |
| 702 | ) |
| 703 | } |
| 704 | |
| 705 | fn hrefs_in(r: &Resp) -> Vec<String> { |
| 706 | let mut h: Vec<_> = statuses(r).into_iter().map(|(h, _)| h).collect(); |
| 707 | h.sort(); |
| 708 | h |
| 709 | } |
| 710 | |
| 711 | #[tokio::test] |
| 712 | async fn calendar_reports() { |
| 713 | let (env, auth) = setup().await; |
| 714 | put(&env, &auth, &format!("{CAL}lunch.ics"), &ics(LUNCH)).await; |
| 715 | put(&env, &auth, &format!("{CAL}weekly.ics"), &ics(WEEKLY)).await; |
| 716 | put(&env, &auth, &format!("{CAL}todo.ics"), &ics(TODO)).await; |
| 717 | |
| 718 | let r = req( |
| 719 | &env, |
| 720 | "PROPFIND", |
| 721 | CAL, |
| 722 | &auth, |
| 723 | &[("depth", "0")], |
| 724 | &propfind_body(&[(DAV, "supported-report-set")]), |
| 725 | ) |
| 726 | .await; |
| 727 | let reports = prop(&parse_multistatus(&r), CAL, DAV, "supported-report-set").unwrap(); |
| 728 | assert_eq!(xml::elements(&reports).count(), 4); |
| 729 | |
| 730 | // multiget: stored bytes back, a miss as 404. |
| 731 | let body = format!( |
| 732 | r#"<c:calendar-multiget xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav"> |
| 733 | <d:prop><d:getetag/><c:calendar-data/></d:prop> |
| 734 | <d:href>{CAL}lunch.ics</d:href><d:href>{CAL}gone.ics</d:href> |
| 735 | </c:calendar-multiget>"# |
| 736 | ); |
| 737 | let r = req(&env, "REPORT", CAL, &auth, &[("depth", "1")], &body).await; |
| 738 | let ms = parse_multistatus(&r); |
| 739 | let lunch = format!("{CAL}lunch.ics"); |
| 740 | // The CR of each CRLF goes out as ` `, which XML parsing keeps. |
| 741 | assert!(r.text().contains(" \n"), "{}", r.text()); |
| 742 | let data = prop_text(&ms, &lunch, CALDAV, "calendar-data").unwrap(); |
| 743 | assert_eq!(data, ics(LUNCH).trim()); |
| 744 | assert!(statuses(&r).contains(&(format!("{CAL}gone.ics"), Some(404)))); |
| 745 | |
| 746 | // Time range: the Monday 2026-01-05 holds only an instance of the weekly |
| 747 | // series, which started a month earlier in Berlin time. |
| 748 | let range = r#"<c:comp-filter name="VEVENT"><c:time-range start="20260105T000000Z" end="20260106T000000Z"/></c:comp-filter>"#; |
| 749 | let r = req( |
| 750 | &env, |
| 751 | "REPORT", |
| 752 | CAL, |
| 753 | &auth, |
| 754 | &[("depth", "1")], |
| 755 | &query(range, ""), |
| 756 | ) |
| 757 | .await; |
| 758 | assert_eq!(hrefs_in(&r), [format!("{CAL}weekly.ics")]); |
| 759 | |
| 760 | // The same with expand: one instance in UTC, without the RRULE. |
| 761 | let expand = r#"<c:calendar-data><c:expand start="20260105T000000Z" end="20260106T000000Z"/></c:calendar-data>"#; |
| 762 | let r = req( |
| 763 | &env, |
| 764 | "REPORT", |
| 765 | CAL, |
| 766 | &auth, |
| 767 | &[("depth", "1")], |
| 768 | &query(range, expand), |
| 769 | ) |
| 770 | .await; |
| 771 | let data = prop_text( |
| 772 | &parse_multistatus(&r), |
| 773 | &format!("{CAL}weekly.ics"), |
| 774 | CALDAV, |
| 775 | "calendar-data", |
| 776 | ) |
| 777 | .unwrap(); |
| 778 | assert!(data.contains("DTSTART:20260105T080000Z"), "{data}"); |
| 779 | assert!(data.contains("RECURRENCE-ID:20260105T080000Z"), "{data}"); |
| 780 | assert!(!data.contains("RRULE"), "{data}"); |
| 781 | |
| 782 | // text-match folds ASCII case by default, and negates on request. |
| 783 | let text = r#"<c:comp-filter name="VEVENT"><c:prop-filter name="SUMMARY"><c:text-match>team lunch</c:text-match></c:prop-filter></c:comp-filter>"#; |
| 784 | let r = req( |
| 785 | &env, |
| 786 | "REPORT", |
| 787 | CAL, |
| 788 | &auth, |
| 789 | &[("depth", "1")], |
| 790 | &query(text, ""), |
| 791 | ) |
| 792 | .await; |
| 793 | assert_eq!(hrefs_in(&r), std::slice::from_ref(&lunch)); |
| 794 | let negated = text.replace("<c:text-match>", r#"<c:text-match negate-condition="yes">"#); |
| 795 | let r = req( |
| 796 | &env, |
| 797 | "REPORT", |
| 798 | CAL, |
| 799 | &auth, |
| 800 | &[("depth", "1")], |
| 801 | &query(&negated, ""), |
| 802 | ) |
| 803 | .await; |
| 804 | assert_eq!(hrefs_in(&r), [format!("{CAL}weekly.ics")]); |
| 805 | let odd = text.replace("<c:text-match>", r#"<c:text-match collation="i;klingon">"#); |
| 806 | let r = req( |
| 807 | &env, |
| 808 | "REPORT", |
| 809 | CAL, |
| 810 | &auth, |
| 811 | &[("depth", "1")], |
| 812 | &query(&odd, ""), |
| 813 | ) |
| 814 | .await; |
| 815 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 816 | assert_eq!( |
| 817 | error_condition(&r), |
| 818 | Name::new(CALDAV, "supported-collation") |
| 819 | ); |
| 820 | |
| 821 | // A VTODO with only DUE matches the range that holds DUE. |
| 822 | let todo = r#"<c:comp-filter name="VTODO"><c:time-range start="20260110T000000Z" end="20260111T000000Z"/></c:comp-filter>"#; |
| 823 | let r = req( |
| 824 | &env, |
| 825 | "REPORT", |
| 826 | CAL, |
| 827 | &auth, |
| 828 | &[("depth", "1")], |
| 829 | &query(todo, ""), |
| 830 | ) |
| 831 | .await; |
| 832 | assert_eq!(hrefs_in(&r), [format!("{CAL}todo.ics")]); |
| 833 | |
| 834 | // Only the components asked for. |
| 835 | let comp = r#"<c:calendar-data><c:comp name="VCALENDAR"><c:comp name="VEVENT"><c:prop name="SUMMARY"/></c:comp></c:comp></c:calendar-data>"#; |
| 836 | let r = req( |
| 837 | &env, |
| 838 | "REPORT", |
| 839 | CAL, |
| 840 | &auth, |
| 841 | &[("depth", "1")], |
| 842 | &query(text, comp), |
| 843 | ) |
| 844 | .await; |
| 845 | let data = prop_text(&parse_multistatus(&r), &lunch, CALDAV, "calendar-data").unwrap(); |
| 846 | assert!( |
| 847 | data.contains("SUMMARY:Team Lunch") |
| 848 | && !data.contains("DTSTART") |
| 849 | && !data.contains("VERSION"), |
| 850 | "{data}" |
| 851 | ); |
| 852 | |
| 853 | let fb = r#"<c:free-busy-query xmlns:c="urn:ietf:params:xml:ns:caldav"><c:time-range start="20260101T000000Z" end="20260106T000000Z"/></c:free-busy-query>"#; |
| 854 | let r = req(&env, "REPORT", CAL, &auth, &[("depth", "1")], fb).await; |
| 855 | assert_eq!(r.status, StatusCode::OK); |
| 856 | assert!( |
| 857 | r.header("content-type") |
| 858 | .unwrap() |
| 859 | .starts_with("text/calendar") |
| 860 | ); |
| 861 | assert!( |
| 862 | r.text() |
| 863 | .contains("FREEBUSY;FBTYPE=BUSY:20260105T080000Z/20260105T083000Z"), |
| 864 | "{}", |
| 865 | r.text() |
| 866 | ); |
| 867 | assert!( |
| 868 | r.text() |
| 869 | .contains("FREEBUSY;FBTYPE=BUSY:20260101T120000Z/20260101T130000Z"), |
| 870 | "{}", |
| 871 | r.text() |
| 872 | ); |
| 873 | |
| 874 | // An address book report on a calendar is refused. |
| 875 | let r = req(&env, "REPORT", CAL, &auth, &[], r#"<card:addressbook-query xmlns:card="urn:ietf:params:xml:ns:carddav"><card:filter/></card:addressbook-query>"#).await; |
| 876 | assert_eq!(error_condition(&r), Name::new(DAV, "supported-report")); |
| 877 | } |
| 878 | |
| 879 | #[tokio::test] |
| 880 | async fn expand_answers_are_capped() { |
| 881 | let (env, auth) = setup().await; |
| 882 | for i in 0..4 { |
| 883 | let hourly = format!( |
| 884 | "BEGIN:VEVENT\r\nUID:h{i}\r\nDTSTAMP:20260101T000000Z\r\nDTSTART:20260101T000000Z\r\n\ |
| 885 | DURATION:PT10M\r\nRRULE:FREQ=HOURLY\r\nSUMMARY:tick\r\nEND:VEVENT\r\n" |
| 886 | ); |
| 887 | put(&env, &auth, &format!("{CAL}h{i}.ics"), &ics(&hourly)).await; |
| 888 | } |
| 889 | // 7200 instances each: three together pass the limit of one answer, one |
| 890 | // alone stays under that of one object. The fourth is cut off. |
| 891 | let expand = r#"<c:calendar-data><c:expand start="20260101T000000Z" end="20261028T000000Z"/></c:calendar-data>"#; |
| 892 | let range = r#"<c:comp-filter name="VEVENT"><c:time-range start="20260101T000000Z" end="20261028T000000Z"/></c:comp-filter>"#; |
| 893 | let r = req(&env, "REPORT", CAL, &auth, &[], &query(range, expand)).await; |
| 894 | assert_eq!(r.status, StatusCode::MULTI_STATUS); |
| 895 | let s = statuses(&r); |
| 896 | assert!(s.contains(&(CAL.to_string(), Some(507))), "{s:?}"); |
| 897 | assert_eq!(s.len(), 4, "{s:?}"); |
| 898 | |
| 899 | // A sync stops at the same limit and resumes after its last member. |
| 900 | let sync = |token: &str| { |
| 901 | format!( |
| 902 | r#"<d:sync-collection xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav"><d:sync-token>{token}</d:sync-token><d:sync-level>1</d:sync-level><d:prop>{expand}</d:prop></d:sync-collection>"# |
| 903 | ) |
| 904 | }; |
| 905 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync("")).await; |
| 906 | let s = statuses(&r); |
| 907 | assert_eq!(s.len(), 4, "{s:?}"); |
| 908 | assert_eq!(s[3], (CAL.to_string(), Some(507))); |
| 909 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&sync_token_of(&r))).await; |
| 910 | assert_eq!(statuses(&r), [(format!("{CAL}h3.ics"), None)]); |
| 911 | } |
| 912 | |
| 913 | #[tokio::test] |
| 914 | async fn sync_collection() { |
| 915 | let (env, auth) = setup().await; |
| 916 | let sync = |token: &str, limit: &str| { |
| 917 | format!( |
| 918 | r#"<d:sync-collection xmlns:d="DAV:"><d:sync-token>{token}</d:sync-token><d:sync-level>1</d:sync-level>{limit}<d:prop><d:getetag/></d:prop></d:sync-collection>"# |
| 919 | ) |
| 920 | }; |
| 921 | put(&env, &auth, &format!("{CAL}a.ics"), &event("a", "A")).await; |
| 922 | put(&env, &auth, &format!("{CAL}b.ics"), &event("b", "B")).await; |
| 923 | |
| 924 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync("", "")).await; |
| 925 | assert_eq!(hrefs_in(&r), [format!("{CAL}a.ics"), format!("{CAL}b.ics")]); |
| 926 | let token = sync_token_of(&r); |
| 927 | |
| 928 | put(&env, &auth, &format!("{CAL}c.ics"), &event("c", "C")).await; |
| 929 | put(&env, &auth, &format!("{CAL}a.ics"), &event("a", "A2")).await; |
| 930 | let r = req(&env, "DELETE", &format!("{CAL}b.ics"), &auth, &[], "").await; |
| 931 | assert_eq!(r.status, StatusCode::NO_CONTENT); |
| 932 | |
| 933 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&token, "")).await; |
| 934 | let mut got = statuses(&r); |
| 935 | got.sort(); |
| 936 | assert_eq!( |
| 937 | got, |
| 938 | [ |
| 939 | (format!("{CAL}a.ics"), None), |
| 940 | (format!("{CAL}b.ics"), Some(404)), |
| 941 | (format!("{CAL}c.ics"), None), |
| 942 | ] |
| 943 | ); |
| 944 | let latest = sync_token_of(&r); |
| 945 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&latest, "")).await; |
| 946 | assert!(statuses(&r).is_empty()); |
| 947 | |
| 948 | // A limit hands out the token of the last change it returned. |
| 949 | let limit = "<d:limit><d:nresults>1</d:nresults></d:limit>"; |
| 950 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&token, limit)).await; |
| 951 | let got = statuses(&r); |
| 952 | assert_eq!(got.len(), 2); |
| 953 | assert_eq!(got[1], (CAL.to_string(), Some(507))); |
| 954 | let r = req( |
| 955 | &env, |
| 956 | "REPORT", |
| 957 | CAL, |
| 958 | &auth, |
| 959 | &[], |
| 960 | &sync(&sync_token_of(&r), ""), |
| 961 | ) |
| 962 | .await; |
| 963 | assert_eq!(statuses(&r).len(), 2); |
| 964 | |
| 965 | for bad in ["urn:dovenest:sync:999-1", "nonsense", &format!("{latest}0")] { |
| 966 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(bad, "")).await; |
| 967 | assert_eq!( |
| 968 | error_condition(&r), |
| 969 | Name::new(DAV, "valid-sync-token"), |
| 970 | "{bad}" |
| 971 | ); |
| 972 | } |
| 973 | } |
| 974 | |
| 975 | #[tokio::test] |
| 976 | async fn addressbook_reports() { |
| 977 | let (env, auth) = setup().await; |
| 978 | let card = |uid: &str, name: &str, mail: &str| { |
| 979 | format!( |
| 980 | "BEGIN:VCARD\r\nVERSION:3.0\r\nUID:{uid}\r\nFN:{name}\r\nEMAIL;TYPE=WORK:{mail}\r\nEND:VCARD\r\n" |
| 981 | ) |
| 982 | }; |
| 983 | put( |
| 984 | &env, |
| 985 | &auth, |
| 986 | &format!("{BOOK}bob.vcf"), |
| 987 | &card("bob", "Bob Builder", "bob@example.com"), |
| 988 | ) |
| 989 | .await; |
| 990 | put( |
| 991 | &env, |
| 992 | &auth, |
| 993 | &format!("{BOOK}ann.vcf"), |
| 994 | &card("ann", "Ann Äpfel", "ann@example.org"), |
| 995 | ) |
| 996 | .await; |
| 997 | let query = |filter: &str, data: &str| { |
| 998 | format!( |
| 999 | r#"<card:addressbook-query xmlns:d="DAV:" xmlns:card="urn:ietf:params:xml:ns:carddav"><d:prop><d:getetag/>{data}</d:prop>{filter}</card:addressbook-query>"# |
| 1000 | ) |
| 1001 | }; |
| 1002 | let email = r#"<card:filter><card:prop-filter name="EMAIL"><card:text-match match-type="ends-with">.ORG</card:text-match></card:prop-filter></card:filter>"#; |
| 1003 | let r = req(&env, "REPORT", BOOK, &auth, &[], &query(email, "")).await; |
| 1004 | assert_eq!(hrefs_in(&r), [format!("{BOOK}ann.vcf")]); |
| 1005 | |
| 1006 | // Unicode case folding is the CardDAV default. |
| 1007 | let fname = r#"<card:filter><card:prop-filter name="FN"><card:text-match match-type="equals">ann äpfel</card:text-match></card:prop-filter></card:filter>"#; |
| 1008 | let r = req( |
| 1009 | &env, |
| 1010 | "REPORT", |
| 1011 | BOOK, |
| 1012 | &auth, |
| 1013 | &[], |
| 1014 | &query( |
| 1015 | fname, |
| 1016 | "<card:address-data><card:prop name=\"FN\"/></card:address-data>", |
| 1017 | ), |
| 1018 | ) |
| 1019 | .await; |
| 1020 | let data = prop_text( |
| 1021 | &parse_multistatus(&r), |
| 1022 | &format!("{BOOK}ann.vcf"), |
| 1023 | CARDDAV, |
| 1024 | "address-data", |
| 1025 | ) |
| 1026 | .unwrap(); |
| 1027 | assert!( |
| 1028 | data.contains("Ann Äpfel") && !data.contains("EMAIL"), |
| 1029 | "{data}" |
| 1030 | ); |
| 1031 | |
| 1032 | let param = r#"<card:filter test="allof"><card:prop-filter name="EMAIL"><card:param-filter name="TYPE"><card:text-match match-type="equals">work</card:text-match></card:param-filter></card:prop-filter><card:prop-filter name="NICKNAME"><card:is-not-defined/></card:prop-filter></card:filter>"#; |
| 1033 | let r = req(&env, "REPORT", BOOK, &auth, &[], &query(param, "")).await; |
| 1034 | assert_eq!(hrefs_in(&r).len(), 2); |
| 1035 | |
| 1036 | let limited = query( |
| 1037 | "<card:filter/><card:limit><card:nresults>1</card:nresults></card:limit>", |
| 1038 | "", |
| 1039 | ); |
| 1040 | let r = req(&env, "REPORT", BOOK, &auth, &[], &limited).await; |
| 1041 | let got = statuses(&r); |
| 1042 | assert_eq!(got.len(), 2); |
| 1043 | assert_eq!(got[1], (BOOK.to_string(), Some(507))); |
| 1044 | |
| 1045 | let body = format!( |
| 1046 | r#"<card:addressbook-multiget xmlns:d="DAV:" xmlns:card="urn:ietf:params:xml:ns:carddav"><d:prop><card:address-data/></d:prop><d:href>{BOOK}bob.vcf</d:href></card:addressbook-multiget>"# |
| 1047 | ); |
| 1048 | let r = req(&env, "REPORT", BOOK, &auth, &[], &body).await; |
| 1049 | let data = prop_text( |
| 1050 | &parse_multistatus(&r), |
| 1051 | &format!("{BOOK}bob.vcf"), |
| 1052 | CARDDAV, |
| 1053 | "address-data", |
| 1054 | ) |
| 1055 | .unwrap(); |
| 1056 | assert!(data.contains("FN:Bob Builder")); |
| 1057 | } |
| 1058 | |
| 1059 | #[tokio::test] |
| 1060 | async fn move_objects() { |
| 1061 | let (env, auth) = setup().await; |
| 1062 | let r = req(&env, "MKCALENDAR", &format!("{HOME}work/"), &auth, &[], "").await; |
| 1063 | assert_eq!(r.status, StatusCode::CREATED); |
| 1064 | put(&env, &auth, &format!("{CAL}a.ics"), &event("a", "A")).await; |
| 1065 | put(&env, &auth, &format!("{CAL}b.ics"), &event("b", "B")).await; |
| 1066 | |
| 1067 | let dest = |p: &str| format!("http://localhost{p}"); |
| 1068 | let r = req( |
| 1069 | &env, |
| 1070 | "MOVE", |
| 1071 | &format!("{CAL}a.ics"), |
| 1072 | &auth, |
| 1073 | &[("destination", &dest(&format!("{HOME}work/a.ics")))], |
| 1074 | "", |
| 1075 | ) |
| 1076 | .await; |
| 1077 | assert_eq!(r.status, StatusCode::CREATED); |
| 1078 | assert_eq!( |
| 1079 | req(&env, "GET", &format!("{CAL}a.ics"), &auth, &[], "") |
| 1080 | .await |
| 1081 | .status, |
| 1082 | StatusCode::NOT_FOUND |
| 1083 | ); |
| 1084 | assert_eq!( |
| 1085 | req(&env, "GET", &format!("{HOME}work/a.ics"), &auth, &[], "") |
| 1086 | .await |
| 1087 | .text(), |
| 1088 | event("a", "A") |
| 1089 | ); |
| 1090 | |
| 1091 | // Overwrite: F refuses an existing destination. |
| 1092 | put(&env, &auth, &format!("{CAL}a2.ics"), &event("a2", "A2")).await; |
| 1093 | let r = req( |
| 1094 | &env, |
| 1095 | "MOVE", |
| 1096 | &format!("{CAL}a2.ics"), |
| 1097 | &auth, |
| 1098 | &[("destination", &format!("{CAL}b.ics")), ("overwrite", "F")], |
| 1099 | "", |
| 1100 | ) |
| 1101 | .await; |
| 1102 | assert_eq!(r.status, StatusCode::PRECONDITION_FAILED); |
| 1103 | let r = req( |
| 1104 | &env, |
| 1105 | "MOVE", |
| 1106 | &format!("{CAL}a2.ics"), |
| 1107 | &auth, |
| 1108 | &[("destination", &format!("{CAL}b.ics"))], |
| 1109 | "", |
| 1110 | ) |
| 1111 | .await; |
| 1112 | assert_eq!(r.status, StatusCode::NO_CONTENT); |
| 1113 | |
| 1114 | // The same UID under another name in the destination. |
| 1115 | put(&env, &auth, &format!("{CAL}dup.ics"), &event("a", "again")).await; |
| 1116 | let r = req( |
| 1117 | &env, |
| 1118 | "MOVE", |
| 1119 | &format!("{CAL}dup.ics"), |
| 1120 | &auth, |
| 1121 | &[("destination", &format!("{HOME}work/other.ics"))], |
| 1122 | "", |
| 1123 | ) |
| 1124 | .await; |
| 1125 | assert_eq!(error_condition(&r), Name::new(CALDAV, "no-uid-conflict")); |
| 1126 | |
| 1127 | // Across kinds is refused. |
| 1128 | let r = req( |
| 1129 | &env, |
| 1130 | "MOVE", |
| 1131 | &format!("{CAL}b.ics"), |
| 1132 | &auth, |
| 1133 | &[("destination", &format!("{BOOK}b.vcf"))], |
| 1134 | "", |
| 1135 | ) |
| 1136 | .await; |
| 1137 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1138 | } |
| 1139 | |
| 1140 | #[tokio::test] |
| 1141 | async fn hrefs_follow_the_requested_spelling() { |
| 1142 | let (env, auth) = setup().await; |
| 1143 | let body = propfind_body(&[(DAV, "displayname")]); |
| 1144 | let r = req( |
| 1145 | &env, |
| 1146 | "PROPFIND", |
| 1147 | "/pim/calendars/ALICE/", |
| 1148 | &auth, |
| 1149 | &[("depth", "1")], |
| 1150 | &body, |
| 1151 | ) |
| 1152 | .await; |
| 1153 | let hrefs = hrefs_in(&r); |
| 1154 | assert!( |
| 1155 | hrefs.iter().all(|h| h.starts_with("/pim/calendars/ALICE/")), |
| 1156 | "{hrefs:?}" |
| 1157 | ); |
| 1158 | } |
| 1159 | |
| 1160 | // --------------------------------------------------------------------------- |
| 1161 | // Sharing, the system address book, rooms and principal search |
| 1162 | // --------------------------------------------------------------------------- |
| 1163 | |
| 1164 | const BOB: &str = "bob"; |
| 1165 | const BOB_PW: &str = "bob12345678"; |
| 1166 | |
| 1167 | /// alice with an event in her default calendar, and bob. |
| 1168 | async fn two_users() -> (Env, Client, String, String) { |
| 1169 | let env = Env::new().await; |
| 1170 | let admin = env.admin().await; |
| 1171 | create_user(&admin, ALICE, PW, &[]).await; |
| 1172 | create_user(&admin, BOB, BOB_PW, &[]).await; |
| 1173 | let alice = basic(ALICE, PW); |
| 1174 | put(&env, &alice, &format!("{CAL}lunch.ics"), &ics(LUNCH)).await; |
| 1175 | (env, admin, alice, basic(BOB, BOB_PW)) |
| 1176 | } |
| 1177 | |
| 1178 | /// The id of alice's default calendar, from the JSON API. |
| 1179 | async fn calendar_id(alice: &Client) -> i64 { |
| 1180 | let r = alice.get("/api/pim/collections").await; |
| 1181 | assert_eq!(r.status, StatusCode::OK, "{}", r.text()); |
| 1182 | r.json() |
| 1183 | .as_array() |
| 1184 | .unwrap() |
| 1185 | .iter() |
| 1186 | .find(|c| c["kind"] == "calendar" && c["mode"].is_null()) |
| 1187 | .unwrap()["id"] |
| 1188 | .as_i64() |
| 1189 | .unwrap() |
| 1190 | } |
| 1191 | |
| 1192 | fn privilege_names(p: &Element) -> Vec<String> { |
| 1193 | xml::elements(p) |
| 1194 | .flat_map(xml::elements) |
| 1195 | .map(|e| e.name.clone()) |
| 1196 | .collect() |
| 1197 | } |
| 1198 | |
| 1199 | #[tokio::test] |
| 1200 | async fn lent_collections() { |
| 1201 | let (env, admin, alice_auth, bob) = two_users().await; |
| 1202 | let alice = login(&env, ALICE, PW).await; |
| 1203 | let id = calendar_id(&alice).await; |
| 1204 | let shares = format!("/api/pim/collections/{id}/shares"); |
| 1205 | |
| 1206 | let r = alice |
| 1207 | .post_json(&shares, &json!({"user": "nobody", "mode": "ro"})) |
| 1208 | .await; |
| 1209 | assert_eq!(r.status, StatusCode::NOT_FOUND); |
| 1210 | let r = alice |
| 1211 | .post_json(&shares, &json!({"user": ALICE, "mode": "ro"})) |
| 1212 | .await; |
| 1213 | assert_eq!(r.status, StatusCode::BAD_REQUEST); |
| 1214 | let r = alice |
| 1215 | .post_json(&shares, &json!({"user": "BOB", "mode": "ro"})) |
| 1216 | .await; |
| 1217 | assert_eq!(r.status, StatusCode::OK, "{}", r.text()); |
| 1218 | let bob_client = login(&env, BOB, BOB_PW).await; |
| 1219 | assert_eq!(bob_client.get(&shares).await.status, StatusCode::NOT_FOUND); |
| 1220 | let listed = bob_client.get("/api/pim/collections").await.json(); |
| 1221 | let lent = listed |
| 1222 | .as_array() |
| 1223 | .unwrap() |
| 1224 | .iter() |
| 1225 | .find(|c| c["id"] == id) |
| 1226 | .unwrap() |
| 1227 | .clone(); |
| 1228 | assert_eq!(lent["mode"], "ro"); |
| 1229 | assert_eq!(lent["owner"], ALICE); |
| 1230 | let shared = format!("/pim/calendars/bob/shared-{id}/"); |
| 1231 | assert_eq!(lent["url"], shared.as_str()); |
| 1232 | |
| 1233 | // bob's home shows it, read-only, with alice as the owner. |
| 1234 | let body = propfind_body(&[ |
| 1235 | (DAV, "displayname"), |
| 1236 | (DAV, "owner"), |
| 1237 | (DAV, "current-user-privilege-set"), |
| 1238 | ]); |
| 1239 | let r = req( |
| 1240 | &env, |
| 1241 | "PROPFIND", |
| 1242 | "/pim/calendars/bob/", |
| 1243 | &bob, |
| 1244 | &[("depth", "1")], |
| 1245 | &body, |
| 1246 | ) |
| 1247 | .await; |
| 1248 | let ms = parse_multistatus(&r); |
| 1249 | assert_eq!( |
| 1250 | prop_text(&ms, &shared, DAV, "displayname").as_deref(), |
| 1251 | Some("Calendar (alice)") |
| 1252 | ); |
| 1253 | assert_eq!( |
| 1254 | hrefs_of(&prop(&ms, &shared, DAV, "owner").unwrap()), |
| 1255 | ["/pim/principals/alice/"] |
| 1256 | ); |
| 1257 | let privs = privilege_names(&prop(&ms, &shared, DAV, "current-user-privilege-set").unwrap()); |
| 1258 | assert_eq!(privs, ["read", "read-current-user-privilege-set"]); |
| 1259 | |
| 1260 | // Read works through every method, writes do not. |
| 1261 | let lunch = format!("{shared}lunch.ics"); |
| 1262 | let r = req(&env, "GET", &lunch, &bob, &[], "").await; |
| 1263 | assert_eq!(r.status, StatusCode::OK); |
| 1264 | let r = req(&env, "REPORT", &shared, &bob, &[], &query("", "")).await; |
| 1265 | assert_eq!(hrefs_in(&r), [lunch.as_str()]); |
| 1266 | let sync = r#"<d:sync-collection xmlns:d="DAV:"><d:sync-token/><d:prop><d:getetag/></d:prop></d:sync-collection>"#; |
| 1267 | let r = req(&env, "REPORT", &shared, &bob, &[], sync).await; |
| 1268 | assert_eq!(hrefs_in(&r), [lunch.as_str()]); |
| 1269 | let r = req( |
| 1270 | &env, |
| 1271 | "PUT", |
| 1272 | &format!("{shared}new.ics"), |
| 1273 | &bob, |
| 1274 | &[], |
| 1275 | &event("new", "x"), |
| 1276 | ) |
| 1277 | .await; |
| 1278 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1279 | assert!(error_condition(&r).is(DAV, "need-privileges")); |
| 1280 | let r = req(&env, "DELETE", &lunch, &bob, &[], "").await; |
| 1281 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1282 | let patch = r#"<d:propertyupdate xmlns:d="DAV:"><d:set><d:prop><d:displayname>Mine</d:displayname></d:prop></d:set></d:propertyupdate>"#; |
| 1283 | let r = req(&env, "PROPPATCH", &shared, &bob, &[], patch).await; |
| 1284 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1285 | |
| 1286 | // Read-write: bob adds an event, alice sees it. Moving it into his own |
| 1287 | // calendar is refused: an object never changes owner. |
| 1288 | let r = alice |
| 1289 | .post_json(&shares, &json!({"user": BOB, "mode": "rw"})) |
| 1290 | .await; |
| 1291 | assert_eq!(r.status, StatusCode::OK); |
| 1292 | put( |
| 1293 | &env, |
| 1294 | &bob, |
| 1295 | &format!("{shared}new.ics"), |
| 1296 | &event("new", "from bob"), |
| 1297 | ) |
| 1298 | .await; |
| 1299 | let r = req(&env, "GET", &format!("{CAL}new.ics"), &alice_auth, &[], "").await; |
| 1300 | assert_eq!(r.status, StatusCode::OK); |
| 1301 | let r = req( |
| 1302 | &env, |
| 1303 | "MOVE", |
| 1304 | &format!("{shared}new.ics"), |
| 1305 | &bob, |
| 1306 | &[("destination", "/pim/calendars/bob/default/new.ics")], |
| 1307 | "", |
| 1308 | ) |
| 1309 | .await; |
| 1310 | assert_eq!(r.status, StatusCode::FORBIDDEN, "{}", r.text()); |
| 1311 | let r = req(&env, "GET", &format!("{CAL}new.ics"), &alice_auth, &[], "").await; |
| 1312 | assert_eq!(r.status, StatusCode::OK); |
| 1313 | let r = req(&env, "PROPPATCH", &shared, &bob, &[], patch).await; |
| 1314 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1315 | |
| 1316 | // bob deleting it only takes it out of his home. |
| 1317 | let r = req(&env, "DELETE", &shared, &bob, &[], "").await; |
| 1318 | assert_eq!(r.status, StatusCode::NO_CONTENT); |
| 1319 | assert_eq!( |
| 1320 | req(&env, "GET", &lunch, &bob, &[], "").await.status, |
| 1321 | StatusCode::NOT_FOUND |
| 1322 | ); |
| 1323 | assert!( |
| 1324 | alice |
| 1325 | .get(&shares) |
| 1326 | .await |
| 1327 | .json() |
| 1328 | .as_array() |
| 1329 | .unwrap() |
| 1330 | .is_empty() |
| 1331 | ); |
| 1332 | let r = req( |
| 1333 | &env, |
| 1334 | "GET", |
| 1335 | &format!("{CAL}lunch.ics"), |
| 1336 | &alice_auth, |
| 1337 | &[], |
| 1338 | "", |
| 1339 | ) |
| 1340 | .await; |
| 1341 | assert_eq!(r.status, StatusCode::OK); |
| 1342 | |
| 1343 | // Revoking, and deleting the borrower, end the loan. |
| 1344 | alice |
| 1345 | .post_json(&shares, &json!({"user": BOB, "mode": "ro"})) |
| 1346 | .await; |
| 1347 | let r = alice |
| 1348 | .delete(&format!("{shares}/{}", user_id(&admin, BOB).await)) |
| 1349 | .await; |
| 1350 | assert_eq!(r.status, StatusCode::OK); |
| 1351 | assert_eq!( |
| 1352 | req(&env, "GET", &lunch, &bob, &[], "").await.status, |
| 1353 | StatusCode::NOT_FOUND |
| 1354 | ); |
| 1355 | alice |
| 1356 | .post_json(&shares, &json!({"user": BOB, "mode": "ro"})) |
| 1357 | .await; |
| 1358 | let r = admin |
| 1359 | .delete(&format!("/api/admin/users/{}", user_id(&admin, BOB).await)) |
| 1360 | .await; |
| 1361 | assert_eq!(r.status, StatusCode::OK); |
| 1362 | assert!( |
| 1363 | alice |
| 1364 | .get(&shares) |
| 1365 | .await |
| 1366 | .json() |
| 1367 | .as_array() |
| 1368 | .unwrap() |
| 1369 | .is_empty() |
| 1370 | ); |
| 1371 | } |
| 1372 | |
| 1373 | const DIR: &str = "/pim/addressbooks/alice/system/"; |
| 1374 | |
| 1375 | #[tokio::test] |
| 1376 | async fn system_address_book() { |
| 1377 | let (env, admin, alice, _) = two_users().await; |
| 1378 | let body = propfind_body(&[(DAV, "getetag"), (CALSERVER, "getctag")]); |
| 1379 | let r = req(&env, "PROPFIND", DIR, &alice, &[("depth", "1")], &body).await; |
| 1380 | let ms = parse_multistatus(&r); |
| 1381 | // admin, alice and bob. |
| 1382 | assert_eq!(ms.len(), 4); |
| 1383 | let ctag = prop_text(&ms, DIR, CALSERVER, "getctag").unwrap(); |
| 1384 | let card = ms.iter().find(|(h, _)| h != DIR).unwrap().0.clone(); |
| 1385 | let r = req(&env, "GET", &card, &alice, &[], "").await; |
| 1386 | assert_eq!(r.status, StatusCode::OK); |
| 1387 | assert!(r.text().contains("EMAIL;TYPE=INTERNET:"), "{}", r.text()); |
| 1388 | |
| 1389 | let q = r#"<card:addressbook-query xmlns:d="DAV:" xmlns:card="urn:ietf:params:xml:ns:carddav"> |
| 1390 | <d:prop><card:address-data/></d:prop> |
| 1391 | <card:filter><card:prop-filter name="FN"><card:text-match>BOB</card:text-match></card:prop-filter></card:filter> |
| 1392 | </card:addressbook-query>"#; |
| 1393 | let r = req(&env, "REPORT", DIR, &alice, &[], q).await; |
| 1394 | assert_eq!(statuses(&r).len(), 1); |
| 1395 | assert!(r.text().contains("FN:bob")); |
| 1396 | |
| 1397 | let sync = |token: &str| { |
| 1398 | format!( |
| 1399 | r#"<d:sync-collection xmlns:d="DAV:"><d:sync-token>{token}</d:sync-token><d:prop><d:getetag/></d:prop></d:sync-collection>"# |
| 1400 | ) |
| 1401 | }; |
| 1402 | let r = req(&env, "REPORT", DIR, &alice, &[], &sync("")).await; |
| 1403 | assert_eq!(statuses(&r).len(), 3); |
| 1404 | let token = sync_token_of(&r); |
| 1405 | let r = req(&env, "REPORT", DIR, &alice, &[], &sync(&token)).await; |
| 1406 | assert!(statuses(&r).is_empty()); |
| 1407 | |
| 1408 | // A new account changes the CTag, and the old token no longer works. |
| 1409 | create_user(&admin, "carol", "carol12345", &[]).await; |
| 1410 | let r = req(&env, "REPORT", DIR, &alice, &[], &sync(&token)).await; |
| 1411 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1412 | assert!(error_condition(&r).is(DAV, "valid-sync-token")); |
| 1413 | let r = req(&env, "PROPFIND", DIR, &alice, &[("depth", "0")], &body).await; |
| 1414 | assert_ne!( |
| 1415 | prop_text(&parse_multistatus(&r), DIR, CALSERVER, "getctag").unwrap(), |
| 1416 | ctag |
| 1417 | ); |
| 1418 | |
| 1419 | let r = req( |
| 1420 | &env, |
| 1421 | "PUT", |
| 1422 | &format!("{DIR}x.vcf"), |
| 1423 | &alice, |
| 1424 | &[], |
| 1425 | "BEGIN:VCARD\r\nVERSION:3.0\r\nFN:x\r\nEND:VCARD\r\n", |
| 1426 | ) |
| 1427 | .await; |
| 1428 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1429 | assert!(error_condition(&r).is(DAV, "need-privileges")); |
| 1430 | assert_eq!( |
| 1431 | req(&env, "DELETE", &card, &alice, &[], "").await.status, |
| 1432 | StatusCode::FORBIDDEN |
| 1433 | ); |
| 1434 | assert_eq!( |
| 1435 | req(&env, "DELETE", DIR, &alice, &[], "").await.status, |
| 1436 | StatusCode::FORBIDDEN |
| 1437 | ); |
| 1438 | let r = req(&env, "MKCOL", DIR, &alice, &[], "").await; |
| 1439 | assert_eq!(r.status, StatusCode::METHOD_NOT_ALLOWED); |
| 1440 | } |
| 1441 | |
| 1442 | #[tokio::test] |
| 1443 | async fn rooms_and_resources() { |
| 1444 | let (env, admin, alice, _) = two_users().await; |
| 1445 | let alice_client = login(&env, ALICE, PW).await; |
| 1446 | let room = json!({"name": "board", "display_name": "Board Room", "kind": "room"}); |
| 1447 | assert_eq!( |
| 1448 | alice_client |
| 1449 | .post_json("/api/admin/rooms", &room) |
| 1450 | .await |
| 1451 | .status, |
| 1452 | StatusCode::FORBIDDEN |
| 1453 | ); |
| 1454 | let r = admin.post_json("/api/admin/rooms", &room).await; |
| 1455 | assert_eq!(r.status, StatusCode::OK, "{}", r.text()); |
| 1456 | let id = r.json()["id"].as_i64().unwrap(); |
| 1457 | assert_eq!(r.json()["url"], "/pim/principals/board/"); |
| 1458 | let taken = json!({"name": "ALICE", "kind": "resource"}); |
| 1459 | assert_eq!( |
| 1460 | admin.post_json("/api/admin/rooms", &taken).await.status, |
| 1461 | StatusCode::CONFLICT |
| 1462 | ); |
| 1463 | let r = admin |
| 1464 | .post_json( |
| 1465 | "/api/admin/users", |
| 1466 | &json!({"name": "Board", "password": "x1234567", "is_admin": false, "roots": []}), |
| 1467 | ) |
| 1468 | .await; |
| 1469 | assert_eq!(r.status, StatusCode::CONFLICT); |
| 1470 | // Not an account: not listed, not editable, no sign-in. |
| 1471 | let users = admin.get("/api/admin/users").await.json(); |
| 1472 | assert!( |
| 1473 | users |
| 1474 | .as_array() |
| 1475 | .unwrap() |
| 1476 | .iter() |
| 1477 | .all(|u| u["name"] != "board") |
| 1478 | ); |
| 1479 | let r = admin |
| 1480 | .put_json( |
| 1481 | &format!("/api/admin/users/{id}"), |
| 1482 | &json!({"password": "x1234567"}), |
| 1483 | ) |
| 1484 | .await; |
| 1485 | assert_eq!(r.status, StatusCode::NOT_FOUND); |
| 1486 | let r = admin.delete(&format!("/api/admin/users/{id}")).await; |
| 1487 | assert_eq!(r.status, StatusCode::NOT_FOUND); |
| 1488 | let r = req(&env, "PROPFIND", "/pim/", &basic("board", ""), &[], "").await; |
| 1489 | assert_eq!(r.status, StatusCode::UNAUTHORIZED); |
| 1490 | let r = Client::new(env.app.clone()) |
| 1491 | .post_json("/api/auth/login", &json!({"name": "board", "password": ""})) |
| 1492 | .await; |
| 1493 | assert_eq!(r.status, StatusCode::UNAUTHORIZED); |
| 1494 | |
| 1495 | let p = "/pim/principals/board/"; |
| 1496 | let body = propfind_body(&[ |
| 1497 | (DAV, "displayname"), |
| 1498 | (CALDAV, "calendar-user-type"), |
| 1499 | (CALDAV, "calendar-user-address-set"), |
| 1500 | (CALDAV, "calendar-home-set"), |
| 1501 | ]); |
| 1502 | let r = req(&env, "PROPFIND", p, &alice, &[], &body).await; |
| 1503 | let ms = parse_multistatus(&r); |
| 1504 | assert_eq!( |
| 1505 | prop_text(&ms, p, DAV, "displayname").as_deref(), |
| 1506 | Some("Board Room") |
| 1507 | ); |
| 1508 | assert_eq!( |
| 1509 | prop_text(&ms, p, CALDAV, "calendar-user-type").as_deref(), |
| 1510 | Some("ROOM") |
| 1511 | ); |
| 1512 | let addresses = hrefs_of(&prop(&ms, p, CALDAV, "calendar-user-address-set").unwrap()); |
| 1513 | assert!(addresses.contains(&"mailto:board@rooms.dovenest.invalid".to_string())); |
| 1514 | assert_eq!( |
| 1515 | hrefs_of(&prop(&ms, p, CALDAV, "calendar-home-set").unwrap()), |
| 1516 | ["/pim/calendars/board/"] |
| 1517 | ); |
| 1518 | |
| 1519 | // Everyone reads the bookings; only admins write them. |
| 1520 | let cal = "/pim/calendars/board/default/"; |
| 1521 | let r = req(&env, "PROPFIND", cal, &alice, &[("depth", "0")], "").await; |
| 1522 | assert_eq!(r.status, StatusCode::MULTI_STATUS); |
| 1523 | let r = req( |
| 1524 | &env, |
| 1525 | "PUT", |
| 1526 | &format!("{cal}b.ics"), |
| 1527 | &alice, |
| 1528 | &[], |
| 1529 | &event("b", "x"), |
| 1530 | ) |
| 1531 | .await; |
| 1532 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1533 | put( |
| 1534 | &env, |
| 1535 | &basic("admin", "admin1234"), |
| 1536 | &format!("{cal}b.ics"), |
| 1537 | &event("b", "x"), |
| 1538 | ) |
| 1539 | .await; |
| 1540 | assert_eq!( |
| 1541 | req(&env, "GET", &format!("{cal}b.ics"), &alice, &[], "") |
| 1542 | .await |
| 1543 | .status, |
| 1544 | StatusCode::OK |
| 1545 | ); |
| 1546 | |
| 1547 | // In the system address book as a location. |
| 1548 | let r = req(&env, "REPORT", DIR, &alice, &[], r#"<card:addressbook-query xmlns:d="DAV:" xmlns:card="urn:ietf:params:xml:ns:carddav"><d:prop><card:address-data/></d:prop><card:filter><card:prop-filter name="KIND"><card:text-match match-type="equals">location</card:text-match></card:prop-filter></card:filter></card:addressbook-query>"#).await; |
| 1549 | assert!(r.text().contains("FN:Board Room"), "{}", r.text()); |
| 1550 | |
| 1551 | let r = admin |
| 1552 | .put_json( |
| 1553 | &format!("/api/admin/rooms/{id}"), |
| 1554 | &json!({"display_name": "Boardroom"}), |
| 1555 | ) |
| 1556 | .await; |
| 1557 | assert_eq!(r.json()["display_name"], "Boardroom"); |
| 1558 | assert_eq!( |
| 1559 | admin |
| 1560 | .get("/api/admin/rooms") |
| 1561 | .await |
| 1562 | .json() |
| 1563 | .as_array() |
| 1564 | .unwrap() |
| 1565 | .len(), |
| 1566 | 1 |
| 1567 | ); |
| 1568 | assert_eq!( |
| 1569 | admin.delete(&format!("/api/admin/rooms/{id}")).await.status, |
| 1570 | StatusCode::OK |
| 1571 | ); |
| 1572 | assert_eq!( |
| 1573 | req(&env, "PROPFIND", p, &alice, &[], "").await.status, |
| 1574 | StatusCode::NOT_FOUND |
| 1575 | ); |
| 1576 | } |
| 1577 | |
| 1578 | #[tokio::test] |
| 1579 | async fn principal_search() { |
| 1580 | let (env, admin, alice, _) = two_users().await; |
| 1581 | admin |
| 1582 | .post_json( |
| 1583 | "/api/admin/rooms", |
| 1584 | &json!({"name": "board", "display_name": "Board Room", "kind": "room"}), |
| 1585 | ) |
| 1586 | .await; |
| 1587 | let principals = "/pim/principals/"; |
| 1588 | |
| 1589 | let r = req(&env, "PROPFIND", principals, &alice, &[("depth", "1")], "").await; |
| 1590 | // The collection, admin, alice, bob and the room. |
| 1591 | assert_eq!(parse_multistatus(&r).len(), 5); |
| 1592 | |
| 1593 | let pps = r#"<d:principal-property-search xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav" test="anyof"> |
| 1594 | <d:property-search><d:prop><d:displayname/></d:prop><d:match>BO</d:match></d:property-search> |
| 1595 | <d:prop><d:displayname/><c:calendar-user-type/></d:prop> |
| 1596 | </d:principal-property-search>"#; |
| 1597 | let r = req(&env, "REPORT", principals, &alice, &[("depth", "0")], pps).await; |
| 1598 | assert_eq!( |
| 1599 | hrefs_in(&r), |
| 1600 | ["/pim/principals/board/", "/pim/principals/bob/"] |
| 1601 | ); |
| 1602 | let ms = parse_multistatus(&r); |
| 1603 | assert_eq!( |
| 1604 | prop_text(&ms, "/pim/principals/board/", CALDAV, "calendar-user-type").as_deref(), |
| 1605 | Some("ROOM") |
| 1606 | ); |
| 1607 | |
| 1608 | let cs = r#"<cs:calendarserver-principal-search xmlns:d="DAV:" xmlns:cs="http://calendarserver.org/ns/" context="location"> |
| 1609 | <cs:search-token>bo</cs:search-token><d:prop><d:displayname/></d:prop> |
| 1610 | </cs:calendarserver-principal-search>"#; |
| 1611 | let r = req(&env, "REPORT", principals, &alice, &[], cs).await; |
| 1612 | assert_eq!(hrefs_in(&r), ["/pim/principals/board/"]); |
| 1613 | |
| 1614 | // At another principal, the own hit still names the own home. |
| 1615 | let own = r#"<d:principal-property-search xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav"> |
| 1616 | <d:property-search><d:prop><d:displayname/></d:prop><d:match>alice</d:match></d:property-search> |
| 1617 | <d:prop><c:calendar-home-set/></d:prop> |
| 1618 | </d:principal-property-search>"#; |
| 1619 | let r = req(&env, "REPORT", "/pim/principals/bob/", &alice, &[], own).await; |
| 1620 | assert!( |
| 1621 | r.text().contains("/pim/calendars/alice/") && !r.text().contains("/pim/calendars/bob/"), |
| 1622 | "{}", |
| 1623 | r.text() |
| 1624 | ); |
| 1625 | |
| 1626 | let set = r#"<d:principal-search-property-set xmlns:d="DAV:"/>"#; |
| 1627 | let r = req(&env, "REPORT", principals, &alice, &[], set).await; |
| 1628 | assert_eq!(r.status, StatusCode::OK); |
| 1629 | assert!(r.text().contains("calendar-user-address-set")); |
| 1630 | |
| 1631 | // Not a collection report. |
| 1632 | let r = req(&env, "REPORT", CAL, &alice, &[], pps).await; |
| 1633 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1634 | } |
| 1635 | |
| 1636 | #[tokio::test] |
| 1637 | async fn bad_filters_are_refused_by_name() { |
| 1638 | let (env, auth) = setup().await; |
| 1639 | let bad = query( |
| 1640 | r#"<c:comp-filter name="VEVENT"><c:time-range start="20260102T000000Z" end="20260101T000000Z"/></c:comp-filter>"#, |
| 1641 | "", |
| 1642 | ); |
| 1643 | let r = req(&env, "REPORT", CAL, &auth, &[], &bad).await; |
| 1644 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1645 | assert!(error_condition(&r).is(CALDAV, "valid-filter")); |
| 1646 | let bad = r#"<card:addressbook-query xmlns:d="DAV:" xmlns:card="urn:ietf:params:xml:ns:carddav"><card:filter test="sometimes"/></card:addressbook-query>"#; |
| 1647 | let r = req(&env, "REPORT", BOOK, &auth, &[], bad).await; |
| 1648 | assert!(error_condition(&r).is(CARDDAV, "valid-filter")); |
| 1649 | } |
| 1650 | |
| 1651 | #[tokio::test] |
| 1652 | async fn other_accounts_get_no_client_properties_or_loans_of_disabled_owners() { |
| 1653 | let (env, admin, alice_auth, bob) = two_users().await; |
| 1654 | let alice = login(&env, ALICE, PW).await; |
| 1655 | let id = calendar_id(&alice).await; |
| 1656 | let r = alice |
| 1657 | .post_json( |
| 1658 | &format!("/api/pim/collections/{id}/shares"), |
| 1659 | &json!({"user": BOB, "mode": "rw"}), |
| 1660 | ) |
| 1661 | .await; |
| 1662 | assert_eq!(r.status, StatusCode::OK, "{}", r.text()); |
| 1663 | |
| 1664 | let principal = "/pim/principals/alice/"; |
| 1665 | let patch = "<d:propertyupdate xmlns:d=\"DAV:\" xmlns:x=\"urn:x\"><d:set><d:prop>\ |
| 1666 | <x:note>private</x:note></d:prop></d:set></d:propertyupdate>"; |
| 1667 | let r = req(&env, "PROPPATCH", principal, &alice_auth, &[], patch).await; |
| 1668 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{}", r.text()); |
| 1669 | let body = propfind_body(&[("urn:x", "note")]); |
| 1670 | let note = |auth: String| { |
| 1671 | let (env, body) = (&env, &body); |
| 1672 | async move { |
| 1673 | req(env, "PROPFIND", principal, &auth, &[("depth", "0")], body) |
| 1674 | .await |
| 1675 | .text() |
| 1676 | .contains("private") |
| 1677 | } |
| 1678 | }; |
| 1679 | assert!(note(alice_auth.clone()).await); |
| 1680 | assert!(!note(bob.clone()).await); |
| 1681 | |
| 1682 | let shared = format!("/pim/calendars/bob/shared-{id}/"); |
| 1683 | let status = || req(&env, "PROPFIND", &shared, &bob, &[("depth", "0")], ""); |
| 1684 | assert_eq!(status().await.status, StatusCode::MULTI_STATUS); |
| 1685 | let uid = user_id(&admin, ALICE).await; |
| 1686 | let r = admin |
| 1687 | .put_json( |
| 1688 | &format!("/api/admin/users/{uid}"), |
| 1689 | &json!({"active": false}), |
| 1690 | ) |
| 1691 | .await; |
| 1692 | assert_eq!(r.status, StatusCode::OK); |
| 1693 | assert_eq!(status().await.status, StatusCode::NOT_FOUND); |
| 1694 | } |
| 1695 | |
| 1696 | #[tokio::test] |
| 1697 | async fn pruned_tombstones_invalidate_old_sync_tokens() { |
| 1698 | let (env, auth) = setup().await; |
| 1699 | let sync = |token: &str| { |
| 1700 | format!( |
| 1701 | r#"<d:sync-collection xmlns:d="DAV:"><d:sync-token>{token}</d:sync-token><d:prop><d:getetag/></d:prop></d:sync-collection>"# |
| 1702 | ) |
| 1703 | }; |
| 1704 | let obj = |n: &str| format!("{CAL}{n}.ics"); |
| 1705 | let todo = |n: &str| ics(&TODO.replace("UID:todo", &format!("UID:{n}"))); |
| 1706 | for n in ["a", "b", "c"] { |
| 1707 | put(&env, &auth, &obj(n), &todo(n)).await; |
| 1708 | } |
| 1709 | let old = sync_token_of(&req(&env, "REPORT", CAL, &auth, &[], &sync("")).await); |
| 1710 | for n in ["a", "b", "c"] { |
| 1711 | req(&env, "DELETE", &obj(n), &auth, &[], "").await; |
| 1712 | } |
| 1713 | let mid = sync_token_of(&req(&env, "REPORT", CAL, &auth, &[], &sync(&old)).await); |
| 1714 | put(&env, &auth, &obj("d"), &todo("d")).await; |
| 1715 | req(&env, "DELETE", &obj("d"), &auth, &[], "").await; |
| 1716 | |
| 1717 | env.state.db.pim_prune(2).await.unwrap(); |
| 1718 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&old)).await; |
| 1719 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1720 | assert!(error_condition(&r).is(DAV, "valid-sync-token")); |
| 1721 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&mid)).await; |
| 1722 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{}", r.text()); |
| 1723 | |
| 1724 | let parse = |t: &str| { |
| 1725 | let (id, seq) = t.rsplit_once(':').unwrap().1.rsplit_once('-').unwrap(); |
| 1726 | (id.parse::<i64>().unwrap(), seq.parse::<i64>().unwrap()) |
| 1727 | }; |
| 1728 | let (id, old_seq) = parse(&old); |
| 1729 | let (_, mid_seq) = parse(&mid); |
| 1730 | let db = &env.state.db; |
| 1731 | assert_eq!(db.pim_changes(id, Some(old_seq), None).await.unwrap(), None); |
| 1732 | assert!( |
| 1733 | db.pim_changes(id, Some(mid_seq), None) |
| 1734 | .await |
| 1735 | .unwrap() |
| 1736 | .is_some() |
| 1737 | ); |
| 1738 | } |
| 1739 | |
| 1740 | #[tokio::test] |
| 1741 | async fn a_cut_initial_sync_resumes_past_pruned_tombstones() { |
| 1742 | let (env, auth) = setup().await; |
| 1743 | let sync = |token: &str| { |
| 1744 | format!( |
| 1745 | r#"<d:sync-collection xmlns:d="DAV:"><d:sync-token>{token}</d:sync-token> |
| 1746 | <d:limit><d:nresults>1</d:nresults></d:limit><d:prop><d:getetag/></d:prop></d:sync-collection>"# |
| 1747 | ) |
| 1748 | }; |
| 1749 | let obj = |n: &str| format!("{CAL}{n}.ics"); |
| 1750 | let todo = |n: &str| ics(&TODO.replace("UID:todo", &format!("UID:{n}"))); |
| 1751 | put(&env, &auth, &obj("x"), &todo("x")).await; |
| 1752 | for n in ["d1", "d2"] { |
| 1753 | put(&env, &auth, &obj(n), &todo(n)).await; |
| 1754 | req(&env, "DELETE", &obj(n), &auth, &[], "").await; |
| 1755 | } |
| 1756 | put(&env, &auth, &obj("y"), &todo("y")).await; |
| 1757 | env.state.db.pim_prune(0).await.unwrap(); |
| 1758 | |
| 1759 | // The first page ends at x, below the pruned tombstones. |
| 1760 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync("")).await; |
| 1761 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{}", r.text()); |
| 1762 | assert!( |
| 1763 | r.text().contains("x.ics") && !r.text().contains("y.ics"), |
| 1764 | "{}", |
| 1765 | r.text() |
| 1766 | ); |
| 1767 | let cut = sync_token_of(&r); |
| 1768 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&cut)).await; |
| 1769 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{}", r.text()); |
| 1770 | assert!(r.text().contains("y.ics"), "{}", r.text()); |
| 1771 | |
| 1772 | // Deletions after the sync began still count: pruning them refuses it. |
| 1773 | put(&env, &auth, &obj("z"), &todo("z")).await; |
| 1774 | req(&env, "DELETE", &obj("z"), &auth, &[], "").await; |
| 1775 | env.state.db.pim_prune(0).await.unwrap(); |
| 1776 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&cut)).await; |
| 1777 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1778 | assert!(error_condition(&r).is(DAV, "valid-sync-token")); |
| 1779 | } |
| 1780 | |
| 1781 | #[tokio::test] |
| 1782 | async fn a_cut_initial_sync_survives_writes_between_its_pages() { |
| 1783 | let (env, auth) = setup().await; |
| 1784 | let sync = |token: &str| { |
| 1785 | format!( |
| 1786 | r#"<d:sync-collection xmlns:d="DAV:"><d:sync-token>{token}</d:sync-token> |
| 1787 | <d:limit><d:nresults>1</d:nresults></d:limit><d:prop><d:getetag/></d:prop></d:sync-collection>"# |
| 1788 | ) |
| 1789 | }; |
| 1790 | let obj = |n: &str| format!("{CAL}{n}.ics"); |
| 1791 | let todo = |n: &str| ics(&TODO.replace("UID:todo", &format!("UID:{n}"))); |
| 1792 | for n in ["a", "b"] { |
| 1793 | put(&env, &auth, &obj(n), &todo(n)).await; |
| 1794 | } |
| 1795 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync("")).await; |
| 1796 | let mut token = sync_token_of(&r); |
| 1797 | for n in ["c", "d"] { |
| 1798 | put(&env, &auth, &obj(n), &todo(n)).await; |
| 1799 | } |
| 1800 | // b, then c (written after the sync began), then d. |
| 1801 | for n in ["b", "c", "d"] { |
| 1802 | let r = req(&env, "REPORT", CAL, &auth, &[], &sync(&token)).await; |
| 1803 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{n}: {}", r.text()); |
| 1804 | assert!(r.text().contains(&format!("{n}.ics")), "{}", r.text()); |
| 1805 | token = sync_token_of(&r); |
| 1806 | } |
| 1807 | } |
| 1808 | |
| 1809 | #[tokio::test] |
| 1810 | async fn mkcol_checks_target_and_values() { |
| 1811 | let (env, auth) = setup().await; |
| 1812 | let r = req(&env, "MKCOL", &format!("{CAL}x.ics"), &auth, &[], "").await; |
| 1813 | assert_eq!(r.status, StatusCode::METHOD_NOT_ALLOWED); |
| 1814 | let body = |color: &str| { |
| 1815 | format!( |
| 1816 | r#"<c:mkcalendar xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:a="http://apple.com/ns/ical/"><d:set><d:prop><a:calendar-color>{color}</a:calendar-color></d:prop></d:set></c:mkcalendar>"# |
| 1817 | ) |
| 1818 | }; |
| 1819 | let work = "/pim/calendars/alice/work/"; |
| 1820 | let r = req(&env, "MKCALENDAR", work, &auth, &[], &body("red")).await; |
| 1821 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1822 | let r = req(&env, "MKCALENDAR", work, &auth, &[], &body("#FF8800AA")).await; |
| 1823 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 1824 | } |
| 1825 | |
| 1826 | async fn alice_pid(env: &Env) -> i64 { |
| 1827 | let user = env |
| 1828 | .state |
| 1829 | .db |
| 1830 | .find_user_by_name(ALICE) |
| 1831 | .await |
| 1832 | .unwrap() |
| 1833 | .unwrap(); |
| 1834 | env.state.db.principal_of(user.id).await.unwrap() |
| 1835 | } |
| 1836 | |
| 1837 | #[tokio::test] |
| 1838 | async fn a_taken_slug_leaves_the_first_collection_alone() { |
| 1839 | use server::db::{PimCollection, PimKind}; |
| 1840 | let (env, _) = setup().await; |
| 1841 | let db = &env.state.db; |
| 1842 | let pid = alice_pid(&env).await; |
| 1843 | let make = |name: &str| PimCollection { |
| 1844 | slug: "work".into(), |
| 1845 | displayname: Some(name.into()), |
| 1846 | components: "VEVENT".into(), |
| 1847 | ..Default::default() |
| 1848 | }; |
| 1849 | let kind = PimKind::Calendar; |
| 1850 | assert!( |
| 1851 | db.pim_create_collection(pid, kind, &make("First"), &[]) |
| 1852 | .await |
| 1853 | .unwrap() |
| 1854 | ); |
| 1855 | assert!( |
| 1856 | !db.pim_create_collection(pid, kind, &make("Second"), &[]) |
| 1857 | .await |
| 1858 | .unwrap() |
| 1859 | ); |
| 1860 | let kept = db.pim_collection(pid, kind, "work").await.unwrap().unwrap(); |
| 1861 | assert_eq!(kept.displayname.as_deref(), Some("First")); |
| 1862 | } |
| 1863 | |
| 1864 | #[tokio::test] |
| 1865 | async fn moving_an_object_onto_itself_changes_nothing() { |
| 1866 | use server::db::{PimCollection, PimKind, PimObject, PimOp, PimWrite, Precondition}; |
| 1867 | let (env, _) = setup().await; |
| 1868 | let db = &env.state.db; |
| 1869 | let pid = alice_pid(&env).await; |
| 1870 | db.pim_ensure_defaults(pid).await.unwrap(); |
| 1871 | let col: PimCollection = db |
| 1872 | .pim_collection(pid, PimKind::Calendar, "default") |
| 1873 | .await |
| 1874 | .unwrap() |
| 1875 | .unwrap(); |
| 1876 | let obj = PimObject { |
| 1877 | name: "a.ics".into(), |
| 1878 | uid: "a".into(), |
| 1879 | component: "VEVENT".into(), |
| 1880 | etag: "\"e\"".into(), |
| 1881 | ..Default::default() |
| 1882 | }; |
| 1883 | db.pim_apply(&[PimOp::Put { |
| 1884 | collection_id: col.id, |
| 1885 | obj, |
| 1886 | data: b"data".to_vec(), |
| 1887 | }]) |
| 1888 | .await |
| 1889 | .unwrap(); |
| 1890 | let before = db |
| 1891 | .pim_collection(pid, PimKind::Calendar, "default") |
| 1892 | .await |
| 1893 | .unwrap() |
| 1894 | .unwrap() |
| 1895 | .seq; |
| 1896 | |
| 1897 | let none = Precondition { |
| 1898 | if_match: None, |
| 1899 | if_none_match: None, |
| 1900 | }; |
| 1901 | let r = db |
| 1902 | .pim_move_object(col.id, "a.ics", col.id, "a.ics", true, &none) |
| 1903 | .await |
| 1904 | .unwrap(); |
| 1905 | assert_eq!(r, PimWrite::Updated); |
| 1906 | let (_, data) = db.pim_object(col.id, "a.ics").await.unwrap().unwrap(); |
| 1907 | assert_eq!(data, b"data"); |
| 1908 | let changes = db |
| 1909 | .pim_changes(col.id, Some(before), None) |
| 1910 | .await |
| 1911 | .unwrap() |
| 1912 | .unwrap(); |
| 1913 | assert!(changes.is_empty(), "{changes:?}"); |
| 1914 | } |
| 1915 | |
| 1916 | #[tokio::test] |
| 1917 | async fn a_deleted_user_gets_the_login_challenge() { |
| 1918 | let env = Env::new().await; |
| 1919 | let admin = env.admin().await; |
| 1920 | create_user(&admin, ALICE, PW, &[]).await; |
| 1921 | let auth = basic(ALICE, PW); |
| 1922 | let r = req(&env, "PROPFIND", HOME, &auth, &[("depth", "0")], "").await; |
| 1923 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{}", r.text()); |
| 1924 | let id = user_id(&admin, ALICE).await; |
| 1925 | let r = admin.delete(&format!("/api/admin/users/{id}")).await; |
| 1926 | assert_eq!(r.status, StatusCode::OK, "{}", r.text()); |
| 1927 | let r = req(&env, "PROPFIND", HOME, &auth, &[("depth", "0")], "").await; |
| 1928 | assert_eq!(r.status, StatusCode::UNAUTHORIZED); |
| 1929 | assert!(r.header("www-authenticate").is_some()); |
| 1930 | } |
| 1931 | |
| 1932 | #[tokio::test] |
| 1933 | async fn mkcol_refuses_long_slugs_and_the_101st_collection() { |
| 1934 | use server::db::PimKind; |
| 1935 | let (env, auth) = setup().await; |
| 1936 | let long = format!("/pim/calendars/alice/{}/", "a".repeat(256)); |
| 1937 | let r = req(&env, "MKCALENDAR", &long, &auth, &[], "").await; |
| 1938 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1939 | let ok = format!("/pim/calendars/alice/{}/", "a".repeat(255)); |
| 1940 | let r = req(&env, "MKCALENDAR", &ok, &auth, &[], "").await; |
| 1941 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 1942 | |
| 1943 | // The cap counts the default calendar, not the inbox. |
| 1944 | let mut n = 0; |
| 1945 | loop { |
| 1946 | let r = req(&env, "MKCALENDAR", &format!("{HOME}c{n}/"), &auth, &[], "").await; |
| 1947 | if r.status != StatusCode::CREATED { |
| 1948 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 1949 | break; |
| 1950 | } |
| 1951 | n += 1; |
| 1952 | assert!(n <= 100, "no limit"); |
| 1953 | } |
| 1954 | let pid = alice_pid(&env).await; |
| 1955 | let all = env.state.db.pim_collections(pid, PimKind::Calendar).await; |
| 1956 | assert_eq!(all.unwrap().len(), 101); |
| 1957 | let r = req( |
| 1958 | &env, |
| 1959 | "MKCOL", |
| 1960 | "/pim/addressbooks/alice/other/", |
| 1961 | &auth, |
| 1962 | &[], |
| 1963 | "", |
| 1964 | ) |
| 1965 | .await; |
| 1966 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 1967 | } |
| 1968 | |
| 1969 | #[tokio::test] |
| 1970 | async fn multiget_answers_each_href_once_and_caps_the_count() { |
| 1971 | let (env, auth) = setup().await; |
| 1972 | put(&env, &auth, &format!("{CAL}todo.ics"), &ics(TODO)).await; |
| 1973 | let multiget = |hrefs: &[String]| { |
| 1974 | let hrefs: String = hrefs |
| 1975 | .iter() |
| 1976 | .map(|h| format!("<d:href>{h}</d:href>")) |
| 1977 | .collect(); |
| 1978 | format!( |
| 1979 | r#"<c:calendar-multiget xmlns:d="DAV:" xmlns:c="urn:ietf:params:xml:ns:caldav"><d:prop><d:getetag/></d:prop>{hrefs}</c:calendar-multiget>"# |
| 1980 | ) |
| 1981 | }; |
| 1982 | let todo = format!("{CAL}todo.ics"); |
| 1983 | let r = req( |
| 1984 | &env, |
| 1985 | "REPORT", |
| 1986 | CAL, |
| 1987 | &auth, |
| 1988 | &[], |
| 1989 | &multiget(&[todo.clone(), todo.clone()]), |
| 1990 | ) |
| 1991 | .await; |
| 1992 | assert_eq!(r.status, StatusCode::MULTI_STATUS); |
| 1993 | assert_eq!(statuses(&r).len(), 1, "{}", r.text()); |
| 1994 | |
| 1995 | let many: Vec<String> = (0..1001).map(|i| format!("{CAL}{i}.ics")).collect(); |
| 1996 | let r = req(&env, "REPORT", CAL, &auth, &[], &multiget(&many)).await; |
| 1997 | let got = statuses(&r); |
| 1998 | assert_eq!(got.len(), 1001); |
| 1999 | assert_eq!(got.last().unwrap(), &(CAL.to_string(), Some(507))); |
| 2000 | } |
| 2001 | |
| 2002 | #[tokio::test] |
| 2003 | async fn a_put_racing_the_collection_delete_never_fails_with_500() { |
| 2004 | let (env, auth) = setup().await; |
| 2005 | let col = "/pim/calendars/alice/race/"; |
| 2006 | for i in 0..20 { |
| 2007 | let r = req(&env, "MKCALENDAR", col, &auth, &[], "").await; |
| 2008 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 2009 | let todo = ics(&TODO.replace("UID:todo", &format!("UID:race{i}"))); |
| 2010 | let path = format!("{col}{i}.ics"); |
| 2011 | let (put, delete) = tokio::join!( |
| 2012 | req(&env, "PUT", &path, &auth, &[], &todo), |
| 2013 | req(&env, "DELETE", col, &auth, &[], ""), |
| 2014 | ); |
| 2015 | assert_eq!(delete.status, StatusCode::NO_CONTENT); |
| 2016 | assert!( |
| 2017 | [StatusCode::CREATED, StatusCode::CONFLICT].contains(&put.status), |
| 2018 | "{}", |
| 2019 | put.status |
| 2020 | ); |
| 2021 | } |
| 2022 | } |
| 2023 | |
| 2024 | #[tokio::test] |
| 2025 | async fn a_proppatch_whose_collection_goes_while_its_body_arrives_is_not_a_500() { |
| 2026 | use tower::ServiceExt; |
| 2027 | let (env, auth) = setup().await; |
| 2028 | let col = "/pim/calendars/alice/race/"; |
| 2029 | let r = req(&env, "MKCALENDAR", col, &auth, &[], "").await; |
| 2030 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 2031 | let patch = r#"<d:propertyupdate xmlns:d="DAV:" xmlns:x="urn:x"><d:set><d:prop> |
| 2032 | <x:note>dead</x:note></d:prop></d:set></d:propertyupdate>"#; |
| 2033 | let (send, arrive) = tokio::sync::oneshot::channel::<()>(); |
| 2034 | let body = axum::body::Body::from_stream(futures_util::stream::once(async move { |
| 2035 | arrive.await.ok(); |
| 2036 | Ok::<_, std::convert::Infallible>(axum::body::Bytes::from(patch)) |
| 2037 | })); |
| 2038 | let request = axum::http::Request::builder() |
| 2039 | .method("PROPPATCH") |
| 2040 | .uri(col) |
| 2041 | .header("host", "files.example.com") |
| 2042 | .header("authorization", &auth) |
| 2043 | .body(body) |
| 2044 | .unwrap(); |
| 2045 | let pending = tokio::spawn(env.app.clone().oneshot(request)); |
| 2046 | tokio::time::sleep(std::time::Duration::from_millis(100)).await; |
| 2047 | let r = req(&env, "DELETE", col, &auth, &[], "").await; |
| 2048 | assert_eq!(r.status, StatusCode::NO_CONTENT); |
| 2049 | send.send(()).unwrap(); |
| 2050 | let r = pending.await.unwrap().unwrap(); |
| 2051 | assert_eq!(r.status(), StatusCode::NOT_FOUND); |
| 2052 | } |
| 2053 | |
| 2054 | #[tokio::test] |
| 2055 | async fn deleting_a_missing_object_records_no_change() { |
| 2056 | use server::db::{PimKind, PimOp}; |
| 2057 | let (env, _) = setup().await; |
| 2058 | let db = &env.state.db; |
| 2059 | let user = db.find_user_by_name(ALICE).await.unwrap().unwrap(); |
| 2060 | let pid = db.principal_of(user.id).await.unwrap(); |
| 2061 | db.pim_ensure_defaults(pid).await.unwrap(); |
| 2062 | let seq = || async { |
| 2063 | db.pim_collection(pid, PimKind::Calendar, "default") |
| 2064 | .await |
| 2065 | .unwrap() |
| 2066 | .unwrap() |
| 2067 | }; |
| 2068 | let before = seq().await; |
| 2069 | let op = PimOp::Delete { |
| 2070 | collection_id: before.id, |
| 2071 | name: "missing.ics".into(), |
| 2072 | }; |
| 2073 | db.pim_apply(&[op]).await.unwrap(); |
| 2074 | assert_eq!(seq().await.seq, before.seq); |
| 2075 | assert!( |
| 2076 | db.pim_changes(before.id, Some(before.seq), None) |
| 2077 | .await |
| 2078 | .unwrap() |
| 2079 | .unwrap() |
| 2080 | .is_empty() |
| 2081 | ); |
| 2082 | } |
| 2083 | |
| 2084 | #[tokio::test] |
| 2085 | async fn dead_properties_are_capped_in_total() { |
| 2086 | let (env, auth) = setup().await; |
| 2087 | let big = "x".repeat(60 * 1024); |
| 2088 | let patch = |names: &[&str]| { |
| 2089 | let props: String = names |
| 2090 | .iter() |
| 2091 | .map(|n| format!("<x:{n}>{big}</x:{n}>")) |
| 2092 | .collect(); |
| 2093 | format!( |
| 2094 | "<d:propertyupdate xmlns:d=\"DAV:\" xmlns:x=\"urn:x\"><d:set><d:prop>{props}</d:prop></d:set></d:propertyupdate>" |
| 2095 | ) |
| 2096 | }; |
| 2097 | let codes = |
| 2098 | |r: &Resp| -> Vec<u16> { parse_multistatus(r)[0].1.iter().map(|(c, _)| *c).collect() }; |
| 2099 | let r = req( |
| 2100 | &env, |
| 2101 | "PROPPATCH", |
| 2102 | CAL, |
| 2103 | &auth, |
| 2104 | &[], |
| 2105 | &patch(&["a", "b", "c", "d"]), |
| 2106 | ) |
| 2107 | .await; |
| 2108 | assert_eq!(codes(&r), [200; 4], "{}", r.text()); |
| 2109 | let r = req(&env, "PROPPATCH", CAL, &auth, &[], &patch(&["e"])).await; |
| 2110 | assert_eq!(codes(&r), [507], "{}", r.text()); |
| 2111 | // Replacing one keeps the total. |
| 2112 | let r = req(&env, "PROPPATCH", CAL, &auth, &[], &patch(&["a"])).await; |
| 2113 | assert_eq!(codes(&r), [200], "{}", r.text()); |
| 2114 | |
| 2115 | let tz = format!( |
| 2116 | "<d:propertyupdate xmlns:d=\"DAV:\" xmlns:c=\"urn:ietf:params:xml:ns:caldav\"><d:set><d:prop>\ |
| 2117 | <c:calendar-timezone>{}</c:calendar-timezone></d:prop></d:set></d:propertyupdate>", |
| 2118 | "y".repeat(70 * 1024) |
| 2119 | ); |
| 2120 | // Checked as a time zone first, then for size. |
| 2121 | let r = req(&env, "PROPPATCH", CAL, &auth, &[], &tz).await; |
| 2122 | assert_eq!(codes(&r), [403], "{}", r.text()); |
| 2123 | let tz = format!( |
| 2124 | "<d:propertyupdate xmlns:d=\"DAV:\" xmlns:c=\"urn:ietf:params:xml:ns:caldav\"><d:set><d:prop>\ |
| 2125 | <c:calendar-timezone>BEGIN:VCALENDAR\r\nVERSION:2.0\r\nPRODID:x\r\nBEGIN:VTIMEZONE\r\n\ |
| 2126 | TZID:Europe/Berlin\r\nX-PAD:{}\r\nBEGIN:STANDARD\r\nDTSTART:19701025T030000\r\n\ |
| 2127 | TZOFFSETFROM:+0200\r\nTZOFFSETTO:+0100\r\nEND:STANDARD\r\nEND:VTIMEZONE\r\n\ |
| 2128 | END:VCALENDAR\r\n</c:calendar-timezone></d:prop></d:set></d:propertyupdate>", |
| 2129 | "y".repeat(70 * 1024) |
| 2130 | ); |
| 2131 | let r = req(&env, "PROPPATCH", CAL, &auth, &[], &tz).await; |
| 2132 | assert_eq!(codes(&r), [507], "{}", r.text()); |
| 2133 | // A protected property stays protected, whatever its size. |
| 2134 | let etag = format!( |
| 2135 | "<d:propertyupdate xmlns:d=\"DAV:\"><d:set><d:prop><d:getetag>{}</d:getetag>\ |
| 2136 | </d:prop></d:set></d:propertyupdate>", |
| 2137 | "z".repeat(70 * 1024) |
| 2138 | ); |
| 2139 | let r = req(&env, "PROPPATCH", CAL, &auth, &[], &etag).await; |
| 2140 | assert_eq!(codes(&r), [403], "{}", r.text()); |
| 2141 | } |
| 2142 | |
| 2143 | #[tokio::test] |
| 2144 | async fn proppatch_follows_document_order() { |
| 2145 | let (env, auth) = setup().await; |
| 2146 | let body = |first: &str, second: &str| { |
| 2147 | let op = |o: &str| format!("<d:{o}><d:prop><x:note>v</x:note></d:prop></d:{o}>"); |
| 2148 | format!( |
| 2149 | "<d:propertyupdate xmlns:d=\"DAV:\" xmlns:x=\"urn:x\">{}{}</d:propertyupdate>", |
| 2150 | op(first), |
| 2151 | op(second) |
| 2152 | ) |
| 2153 | }; |
| 2154 | let props = |
| 2155 | "<d:propfind xmlns:d=\"DAV:\" xmlns:x=\"urn:x\"><d:prop><x:note/></d:prop></d:propfind>"; |
| 2156 | for (first, second, kept) in [("set", "remove", false), ("remove", "set", true)] { |
| 2157 | let r = req(&env, "PROPPATCH", CAL, &auth, &[], &body(first, second)).await; |
| 2158 | assert_eq!(r.status, StatusCode::MULTI_STATUS, "{}", r.text()); |
| 2159 | let r = req(&env, "PROPFIND", CAL, &auth, &[("depth", "0")], props).await; |
| 2160 | let ms = parse_multistatus(&r); |
| 2161 | assert_eq!( |
| 2162 | prop(&ms, CAL, "urn:x", "note").is_some(), |
| 2163 | kept, |
| 2164 | "{first} then {second}" |
| 2165 | ); |
| 2166 | } |
| 2167 | } |
| 2168 | |
| 2169 | #[tokio::test] |
| 2170 | async fn long_names_and_405s() { |
| 2171 | let (env, auth) = setup().await; |
| 2172 | let long = format!("{CAL}{}.ics", "n".repeat(300)); |
| 2173 | let r = req(&env, "PUT", &long, &auth, &[], &ics(LUNCH)).await; |
| 2174 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 2175 | let short = format!("{CAL}short.ics"); |
| 2176 | let r = req(&env, "PUT", &short, &auth, &[], &ics(LUNCH)).await; |
| 2177 | assert_eq!(r.status, StatusCode::CREATED, "{}", r.text()); |
| 2178 | let r = req(&env, "MOVE", &short, &auth, &[("destination", &long)], "").await; |
| 2179 | assert_eq!(r.status, StatusCode::FORBIDDEN); |
| 2180 | |
| 2181 | // An object stored under a long name before the limit can still be updated. |
| 2182 | let db = &env.state.db; |
| 2183 | let pid = db.pim_principal("alice").await.unwrap().unwrap().id; |
| 2184 | let col = db |
| 2185 | .pim_collection(pid, server::db::PimKind::Calendar, "default") |
| 2186 | .await |
| 2187 | .unwrap() |
| 2188 | .unwrap(); |
| 2189 | let (mut obj, data) = db.pim_object(col.id, "short.ics").await.unwrap().unwrap(); |
| 2190 | obj.name = long.rsplit('/').next().unwrap().to_string(); |
| 2191 | db.pim_apply(&[ |
| 2192 | server::db::PimOp::Delete { |
| 2193 | collection_id: col.id, |
| 2194 | name: "short.ics".into(), |
| 2195 | }, |
| 2196 | server::db::PimOp::Put { |
| 2197 | collection_id: col.id, |
| 2198 | obj, |
| 2199 | data, |
| 2200 | }, |
| 2201 | ]) |
| 2202 | .await |
| 2203 | .unwrap(); |
| 2204 | let r = req( |
| 2205 | &env, |
| 2206 | "PUT", |
| 2207 | &long, |
| 2208 | &auth, |
| 2209 | &[], |
| 2210 | &ics(&LUNCH.replace("Team", "Long")), |
| 2211 | ) |
| 2212 | .await; |
| 2213 | assert_eq!(r.status, StatusCode::NO_CONTENT, "{}", r.text()); |
| 2214 | |
| 2215 | let r = req(&env, "PUT", CAL, &auth, &[], &ics(LUNCH)).await; |
| 2216 | assert_eq!(r.status, StatusCode::METHOD_NOT_ALLOWED); |
| 2217 | let allow = r.header("allow").unwrap(); |
| 2218 | assert!( |
| 2219 | allow.contains("PROPFIND") && !allow.contains("PUT"), |
| 2220 | "{allow}" |
| 2221 | ); |
| 2222 | } |
| 2223 |