vidarchive

vidarchive/internal/server/server_test.go
server_test.go
⎇
Raw
1package server
2
3import (
4 "io"
5 "net/http"
6 "net/http/httptest"
7 "net/url"
8 "os"
9 "os/exec"
10 "path/filepath"
11 "regexp"
12 "strings"
13 "testing"
14
15 "vidarchive/internal/config"
16 "vidarchive/internal/database"
17 "vidarchive/internal/handler"
18 "vidarchive/internal/repository"
19 "vidarchive/internal/service"
20 "vidarchive/internal/worker"
21)
22
23func setupTestServer(t *testing.T) (*Server, *config.Config, func()) {
24 t.Helper()
25 dataDir := t.TempDir()
26 t.Setenv("VIDARCHIVE_DATA_DIR", dataDir)
27
28 cfg := config.New()
29 if err := os.MkdirAll(cfg.LibraryDir, 0755); err != nil {
30 t.Fatalf("create library dir: %v", err)
31 }
32 if err := os.MkdirAll(cfg.TempDir, 0755); err != nil {
33 t.Fatalf("create temp dir: %v", err)
34 }
35
36 db, err := database.New(cfg)
37 if err != nil {
38 t.Fatalf("init db: %v", err)
39 }
40
41 presetRepo := repository.NewPresetRepository(db)
42 downloadRepo := repository.NewDownloadRepository(db)
43 settingsRepo := repository.NewSettingsRepository(db)
44
45 presetSvc := service.NewPresetService(presetRepo)
46 librarySvc := service.NewLibraryService(cfg.LibraryDir)
47 settingsSvc := service.NewSettingsService(settingsRepo)
48 downloadSvc := service.NewDownloadService(downloadRepo, librarySvc, presetSvc, settingsSvc, cfg)
49 workerPool := worker.New(downloadSvc, cfg.Workers)
50
51 h, err := handler.New(cfg, presetSvc, downloadSvc, librarySvc, settingsSvc, workerPool)
52 if err != nil {
53 t.Fatalf("init handler: %v", err)
54 }
55
56 srv := New(cfg, h)
57 cleanup := func() {
58 workerPool.Stop()
59 db.Close()
60 }
61 return srv, cfg, cleanup
62}
63
64func createItem(t *testing.T, libraryDir, relPath, name string, files map[string]string) {
65 t.Helper()
66 itemDir := filepath.Join(libraryDir, relPath)
67 if err := os.MkdirAll(itemDir, 0755); err != nil {
68 t.Fatalf("create item dir: %v", err)
69 }
70 marker := filepath.Join(itemDir, ".vidarchive-item.toml")
71 if err := os.WriteFile(marker, []byte("name = \""+name+"\"\nduration = -1\n"), 0644); err != nil {
72 t.Fatalf("write marker: %v", err)
73 }
74 for filename, content := range files {
75 path := filepath.Join(itemDir, filename)
76 if err := os.WriteFile(path, []byte(content), 0644); err != nil {
77 t.Fatalf("write file %s: %v", filename, err)
78 }
79 }
80}
81
82func TestNestedLibraryItem(t *testing.T) {
83 srv, cfg, cleanup := setupTestServer(t)
84 defer cleanup()
85
86 createItem(t, cfg.LibraryDir, "test/My Item [id]", "My Item", map[string]string{
87 "My Item [id].mp4": "dummy video",
88 })
89
90 router := srv.Router()
91
92 tests := []string{
93 "/library/item/test/My%20Item%20%5Bid%5D",
94 "/library/item/test/My+Item+%5Bid%5D",
95 }
96 for _, path := range tests {
97 req := httptest.NewRequest("GET", path, nil)
98 w := httptest.NewRecorder()
99 router.ServeHTTP(w, req)
100 if w.Code != http.StatusOK {
101 body, _ := io.ReadAll(w.Body)
102 t.Errorf("%s: expected 200, got %d: %s", path, w.Code, string(body))
103 }
104 }
105}
106
107func TestMediaFileQueryDecoding(t *testing.T) {
108 srv, cfg, cleanup := setupTestServer(t)
109 defer cleanup()
110
111 createItem(t, cfg.LibraryDir, "My Item [id]", "My Item", map[string]string{
112 "My Item [id].mp4": "dummy video",
113 "My+Other.mp4": "dummy video plus",
114 })
115
116 router := srv.Router()
117
118 tests := []struct {
119 path string
120 expected int
121 }{
122 {"/media/item/My%20Item%20%5Bid%5D?file=My+Item+%5Bid%5D.mp4", http.StatusOK},
123 {"/media/item/My%20Item%20%5Bid%5D?file=My%20Item%20%5Bid%5D.mp4", http.StatusOK},
124 {"/media/item/My%20Item%20%5Bid%5D?file=My%2BOther.mp4", http.StatusOK},
125 {"/media/item/My%20Item%20%5Bid%5D?file=missing.mp4", http.StatusNotFound},
126 }
127 for _, tc := range tests {
128 req := httptest.NewRequest("GET", tc.path, nil)
129 w := httptest.NewRecorder()
130 router.ServeHTTP(w, req)
131 if w.Code != tc.expected {
132 body, _ := io.ReadAll(w.Body)
133 t.Errorf("%s: expected %d, got %d: %s", tc.path, tc.expected, w.Code, string(body))
134 }
135 }
136}
137
138func TestPathTraversalBlocked(t *testing.T) {
139 srv, cfg, cleanup := setupTestServer(t)
140 defer cleanup()
141
142 outside := filepath.Join(cfg.DataDir, "secret")
143 if err := os.MkdirAll(outside, 0755); err != nil {
144 t.Fatalf("create outside dir: %v", err)
145 }
146 marker := filepath.Join(outside, ".vidarchive-item.toml")
147 if err := os.WriteFile(marker, []byte("name = \"secret\"\nduration = -1\n"), 0644); err != nil {
148 t.Fatalf("write marker: %v", err)
149 }
150
151 router := srv.Router()
152
153 req := httptest.NewRequest("GET", "/library/item/../secret", nil)
154 w := httptest.NewRecorder()
155 router.ServeHTTP(w, req)
156 if w.Code != http.StatusNotFound {
157 t.Errorf("expected 404 for path traversal, got %d", w.Code)
158 }
159}
160
161func TestPerFileExistingThumbnailServed(t *testing.T) {
162 srv, cfg, cleanup := setupTestServer(t)
163 defer cleanup()
164
165 // A pre-existing per-file thumbnail (<stem>.thumbnail.webp) is served for the
166 // matching ?file= request without re-extraction.
167 createItem(t, cfg.LibraryDir, "thumb-item", "Thumb Item", map[string]string{
168 "video.mp4": "dummy video",
169 "video.thumbnail.webp": "GENERATED-THUMB",
170 })
171
172 router := srv.Router()
173 req := httptest.NewRequest("GET", "/media/item/thumb-item/thumbnail?file=video.mp4", nil)
174 w := httptest.NewRecorder()
175 router.ServeHTTP(w, req)
176 if w.Code != http.StatusOK {
177 body, _ := io.ReadAll(w.Body)
178 t.Fatalf("expected 200, got %d: %s", w.Code, string(body))
179 }
180 if body, _ := io.ReadAll(w.Body); string(body) != "GENERATED-THUMB" {
181 t.Errorf("expected the existing per-file thumbnail, got %q", string(body))
182 }
183}
184
185func TestAudioThumbnailPlaceholder(t *testing.T) {
186 srv, cfg, cleanup := setupTestServer(t)
187 defer cleanup()
188
189 createItem(t, cfg.LibraryDir, "audio-item", "Audio Item", map[string]string{
190 "song.mp3": "dummy audio",
191 })
192
193 router := srv.Router()
194 req := httptest.NewRequest("GET", "/media/item/audio-item/thumbnail", nil)
195 w := httptest.NewRecorder()
196 router.ServeHTTP(w, req)
197 if w.Code != http.StatusOK {
198 body, _ := io.ReadAll(w.Body)
199 t.Fatalf("expected 200, got %d: %s", w.Code, string(body))
200 }
201 body, _ := io.ReadAll(w.Body)
202 if len(body) == 0 {
203 t.Errorf("placeholder thumbnail body was empty")
204 }
205}
206
207func TestMultiFileCardThumbnailURLsDecodeToFilenames(t *testing.T) {
208 srv, cfg, cleanup := setupTestServer(t)
209 defer cleanup()
210
211 // Filenames with spaces are the case that broke: the template must emit a
212 // query value that the handler decodes back to the exact filename (the bug
213 // was double-escaping spaces to %2b, which decodes to '+').
214 files := map[string]string{
215 "01 - Color Bars.mp4": "v",
216 "02 - Test Pattern.mp4": "v",
217 }
218 createItem(t, cfg.LibraryDir, "multi", "Multi", files)
219
220 req := httptest.NewRequest("GET", "/library", nil)
221 w := httptest.NewRecorder()
222 srv.Router().ServeHTTP(w, req)
223 body, _ := io.ReadAll(w.Body)
224
225 re := regexp.MustCompile(`thumbnail\?file=([^"]+)`)
226 matches := re.FindAllStringSubmatch(string(body), -1)
227 if len(matches) != len(files) {
228 t.Fatalf("expected %d per-file thumbnail URLs in the card, got %d", len(files), len(matches))
229 }
230 for _, m := range matches {
231 vals, err := url.ParseQuery("file=" + m[1])
232 if err != nil {
233 t.Fatalf("bad query %q: %v", m[1], err)
234 }
235 got := vals.Get("file")
236 if _, ok := files[got]; !ok {
237 t.Errorf("thumbnail file=%q decodes to %q, which is not a real filename (double-encoding regression)", m[1], got)
238 }
239 }
240}
241
242func TestListingDoesNotExtractThumbnails(t *testing.T) {
243 srv, cfg, cleanup := setupTestServer(t)
244 defer cleanup()
245
246 createItem(t, cfg.LibraryDir, "novid", "No Thumb", map[string]string{
247 "video.mp4": "dummy video",
248 })
249
250 router := srv.Router()
251 req := httptest.NewRequest("GET", "/library", nil)
252 w := httptest.NewRecorder()
253 router.ServeHTTP(w, req)
254 if w.Code != http.StatusOK {
255 t.Fatalf("expected 200, got %d", w.Code)
256 }
257
258 // Rendering the listing must not have created any thumbnail file.
259 entries, err := os.ReadDir(filepath.Join(cfg.LibraryDir, "novid"))
260 if err != nil {
261 t.Fatal(err)
262 }
263 for _, e := range entries {
264 if strings.Contains(e.Name(), ".thumbnail.") {
265 t.Errorf("listing extracted a thumbnail (%q) — should happen on request only", e.Name())
266 }
267 }
268}
269
270func TestGeneratedThumbnailServedOverIcon(t *testing.T) {
271 srv, cfg, cleanup := setupTestServer(t)
272 defer cleanup()
273
274 createItem(t, cfg.LibraryDir, "gen", "Gen", map[string]string{
275 "video.mp4": "dummy video",
276 "video.thumbnail.webp": "WEBPDATA",
277 })
278
279 router := srv.Router()
280 req := httptest.NewRequest("GET", "/media/item/gen/thumbnail?file=video.mp4", nil)
281 w := httptest.NewRecorder()
282 router.ServeHTTP(w, req)
283 if w.Code != http.StatusOK {
284 t.Fatalf("expected 200, got %d", w.Code)
285 }
286 if body, _ := io.ReadAll(w.Body); string(body) != "WEBPDATA" {
287 t.Errorf("expected generated thumbnail contents, got %q", string(body))
288 }
289}
290
291func TestThumbnailExtractedOnRequest(t *testing.T) {
292 if _, err := exec.LookPath("ffmpeg"); err != nil {
293 t.Skip("ffmpeg not on PATH")
294 }
295 srv, cfg, cleanup := setupTestServer(t)
296 defer cleanup()
297
298 itemDir := filepath.Join(cfg.LibraryDir, "realvid")
299 createItem(t, cfg.LibraryDir, "realvid", "Real", nil)
300 cmd := exec.Command("ffmpeg", "-hide_banner", "-loglevel", "error",
301 "-f", "lavfi", "-i", "testsrc=duration=3:size=64x64:rate=5",
302 "-pix_fmt", "yuv420p", filepath.Join(itemDir, "realvid.mp4"), "-y")
303 if out, err := cmd.CombinedOutput(); err != nil {
304 t.Fatalf("make test video: %v\n%s", err, out)
305 }
306
307 router := srv.Router()
308 req := httptest.NewRequest("GET", "/media/item/realvid/thumbnail?file=realvid.mp4", nil)
309 w := httptest.NewRecorder()
310 router.ServeHTTP(w, req)
311 if w.Code != http.StatusOK {
312 t.Fatalf("expected 200, got %d", w.Code)
313 }
314 if ct := w.Header().Get("Content-Type"); !strings.HasPrefix(ct, "image/") {
315 t.Errorf("expected image content-type, got %q", ct)
316 }
317 body, _ := io.ReadAll(w.Body)
318 if len(body) == 0 {
319 t.Error("served thumbnail body was empty")
320 }
321
322 // A real thumbnail file should now exist on disk, with no temp leftovers.
323 entries, _ := os.ReadDir(itemDir)
324 var found bool
325 for _, e := range entries {
326 if strings.Contains(e.Name(), ".thumbnail.") {
327 found = true
328 }
329 if strings.Contains(e.Name(), ".tmp") {
330 t.Errorf("leftover temp file %q", e.Name())
331 }
332 }
333 if !found {
334 t.Error("no thumbnail file written to disk after request")
335 }
336}
337
338func TestLibraryPageIsFast(t *testing.T) {
339 srv, cfg, cleanup := setupTestServer(t)
340 defer cleanup()
341
342 for i := 0; i < 50; i++ {
343 createItem(t, cfg.LibraryDir, "item-"+string(rune('a'+i)), "Item", map[string]string{
344 "video.mp4": "dummy",
345 })
346 }
347
348 router := srv.Router()
349 req := httptest.NewRequest("GET", "/library", nil)
350 w := httptest.NewRecorder()
351 router.ServeHTTP(w, req)
352 if w.Code != http.StatusOK {
353 body, _ := io.ReadAll(w.Body)
354 t.Fatalf("expected 200, got %d: %s", w.Code, string(body))
355 }
356}
357